Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize bibtex acts strangely #1504

Closed
melTr opened this issue Jun 18, 2016 · 5 comments
Closed

Normalize bibtex acts strangely #1504

melTr opened this issue Jun 18, 2016 · 5 comments
Assignees
@bruehldev
Labels
bug Confirmed bugs or reports that are very likely to be bugs cleanup-ops status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@melTr
Copy link
Contributor

melTr commented Jun 18, 2016

JabRef version 3.3 or 3.4 Ubuntu 14.04
I use "normalize to Bibtex" quite often on manual entries. Before, the result was almost often correct. But in this version, I can't get it.

Paste those authors:
Cristina Bosoi, Mariana Oliveira, Rafael Ochoa Sanchez, Mélanie Tremblay, Gabrie TenHave, Nicoolas Deutz, Christopher F. Rose, Chantal Bemeur

Normalize to bibtex give : Cristina Bosoi, Mariana Oliveira, Rafael Ochoa Sanchez Mélanie Tremblay Gabrie TenHave Nicoolas Deutz Christopher F. Rose Chantal Bemeur
which make no sense and I have to add "and" between each name.

In version 2.10 or 3.2. It gave :
Bosoi, Cristina and Oliveira, Mariana and Sanchez, Rafael Ochoa and Tremblay, Mélanie and Gabrie TenHave and Deutz, Nicoolas and Christopher F. Rose and Bemeur, Chantal
@matthiasgeiger matthiasgeiger added the bug Confirmed bugs or reports that are very likely to be bugs label Jun 20, 2016
@matthiasgeiger
Copy link
Member

Thanks for your report!

I can confirm this behavior in JabRef 3.4 and the current development versions.

We are currently working on an improvement of the "Normalize to BibTeX" functionality (see #1181 and #1470).

This was referenced Jun 20, 2016
Closed
Merged
bruehldev added a commit to bruehldev/jabref that referenced this issue Jun 27, 2016
@bruehldev
Fixes JabRef#1181 and JabRef#1504: Improved "Normalize to BibTeX name…
b28a926 
… format"

Added the jr, sr,... special cases for semicolon partition.
Fixed to avoid the "and", "{", ";" cases.
Added Test for every case.
@bruehldev
Copy link
Contributor

I've added the possibility to normalize the comma separated names. Also i trimmed spaces of the names and separated the different syntax cases to enable more stability.
The related tests are in the test file.

bruehldev added a commit to bruehldev/jabref that referenced this issue Aug 15, 2016
@bruehldev
Fixes JabRef#1181 and JabRef#1504: Improved "Normalize to BibTeX name…
a68f862 
… format"

Added the jr, sr,... special cases for semicolon partition.
Fixed to avoid the "and", "{", ";" cases.
Added Test for every case.
bruehldev added a commit to bruehldev/jabref that referenced this issue Aug 22, 2016
@bruehldev
Fixes JabRef#1181 and JabRef#1504: Improved "Normalize to BibTeX name…
3f62d77 
… format"

Added the jr, sr,... special cases for semicolon partition.
Fixed to avoid the "and", "{", ";" cases.
Added Test for every case.
bruehldev added a commit to bruehldev/jabref that referenced this issue Sep 1, 2016
@bruehldev
Fixes JabRef#1181 and JabRef#1504: Improved "Normalize to BibTeX name…
6f81616 
… format"

Added the jr, sr,... special cases for semicolon partition.
Fixed to avoid the "and", "{", ";" cases.
Added Test for every case.
bruehldev added a commit to bruehldev/jabref that referenced this issue Sep 6, 2016
@bruehldev
Fixes JabRef#1181 and JabRef#1504: Improved "Normalize to BibTeX name…
aaa2031 
… format"

Added the jr, sr,... special cases for semicolon partition.
Fixed to avoid the "and", "{", ";" cases.
Added Test for every case.
bruehldev added a commit to bruehldev/jabref that referenced this issue Sep 8, 2016
@bruehldev
Fixes JabRef#1181 and JabRef#1504: Improved "Normalize to BibTeX name…
7486d51 
… format"

Added the jr, sr,... special cases for semicolon partition.
Fixed to avoid the "and", "{", ";" cases.
Added Test for every case.
@tobiasdiez
Copy link
Member

@bruehldev is this fixed now?

@stefan-kolb
Copy link
Member

What's the status here? This was never merged?!

@lenhard lenhard added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Feb 10, 2017
@lenhard
Copy link
Member

lenhard commented Feb 15, 2017

I just tested this in the current development version and the string:

Cristina Bosoi, Mariana Oliveira, Rafael Ochoa Sanchez, Mélanie Tremblay, Gabrie TenHave, Nicoolas Deutz, Christopher F. Rose, Chantal Bemeur

turns into

Bosoi, Cristina and Oliveira, Mariana and Sanchez, Rafael Ochoa and Tremblay, Mélanie and TenHave, Gabrie and Deutz, Nicoolas and Rose, Christopher F. and Bemeur, Chantal

which is the desired result, as far as I can see. There is also a test case for exactly that in NormalizeNamesFormatterTest.

So this can be closed.

@lenhard lenhard closed this as completed Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruehldev bruehldev

Labels
bug Confirmed bugs or reports that are very likely to be bugs cleanup-ops status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@matthiasgeiger @melTr @lenhard @stefan-kolb @tobiasdiez @bruehldev