Fixes #1181: Improved "Normalize to BibTeX name format" #1470

bruehldev · 2016-06-02T19:22:10Z

Fixed #1181: Improved "Normalize to BibTeX name format": Separated names with colons only work now

Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)

koppor · 2016-06-02T19:50:10Z

It shows The command "./gradlew check integrationTest" exited with 1, which should not be caused by this PR. LGTM.

stefan-kolb · 2016-06-02T19:57:52Z

The problem are always the GUI tests. It's annoying...

stefan-kolb · 2016-06-02T19:59:03Z

src/main/java/net/sf/jabref/logic/formatter/bibtexfields/NormalizeNamesFormatter.java

@@ -36,6 +36,28 @@ public String getKey() {

    @Override
    public String format(String value) {
+        // Fixes https://github.com/JabRef/jabref/issues/1181


Please remove this comment. It's not relevant that this solved some issue.

tobiasdiez · 2016-06-02T20:43:01Z

As I said in #1181, there should be some additional handling of author names with Jr part like von Last, Jr, First. Moreover, the code probably has to go into the AuthorList parser.

stefan-kolb · 2016-06-02T20:52:17Z

src/test/java/net/sf/jabref/logic/formatter/bibtexfields/NormalizeNamesFormatterTest.java

-    public void testSeperatedCommaNames() {
-        // Testing the issue "https://github.com/JabRef/jabref/issues/1181".
-        // Every second comma should become a semicolon
+    public void testSeperatedCommaNames_EverySecondCommaBecomesAnAnd() {


why not describe the use case here? allowConcatenationOfAuthorsWithCommas or testConcatenationOfAuthorsWithCommas

koppor · 2016-06-02T22:14:56Z

I think (as outlined in #1181 (comment)), that Jr are seldom and that I need a thing working for 80% of the cases and not covering 100%. We just looked at AuthorListParse.getAuthor() and it seems to be very difficult to include the special treatment there. We would have to include hard coded strings for jrPart to be able to distinguish them from other strings.

The fix works for me and really improves my workflow.

stefan-kolb · 2016-06-03T07:03:32Z

Do you often have authors separated by colons? I would have guessed this is also a very seldom case.

tobiasdiez · 2016-06-03T08:42:41Z

In my opinion, the cleanup operations / save actions should respect the bib(la)tex standard before anything else. Otherwise they keep reformatting valid bibtex and thus become useless.

Sorry, but I just can't see an automatic way to correctly determine the authors if they are only separated by comma. Consider strings like
Surname, Jr, First, Surname2, First2
or Surname, First, First2 Surname2.

stefan-kolb · 2016-06-03T08:44:02Z

Is a comma even allowed for separating authors in Bib(la)tex?

koppor · 2016-06-03T09:10:04Z

IMHO we discussed the separator at some other place that biblatex can be configured to use something else than and, but I do not find the source.

In bibtex, and really has to be used.

This tweak happens only if only commans and 2 or more commas and even number of commas

Thus, it will currently. destroy both of your examples. - We can include a checker if your special cases ( Jr) and parts with one word only (Surname, First at the second example) and not handle these.

I still think that you have these special cases, but that these are not the majority of the cases.

tobiasdiez · 2016-06-03T09:49:19Z

I'm fine with every change as long as standard bibtex names don't get destroyed. So in particular:

Last, First and Last2, First2 and Last3, First3
Last, First and Last2, First2 and Last3, First3 and First4 Last4 (this should be converted to Last4, First4)
Last, Jr, First and Last2, First2
Last and Last2, First2 and Last3, First3 and Last4, First4

Moreover, semi-correct names using semicolon should still be converted to the correct format (i.e. replace every and in the above examples with a semicolon in the input). Please add corresponding tests.

koppor · 2016-06-03T11:52:31Z

src/main/java/net/sf/jabref/logic/formatter/bibtexfields/NormalizeNamesFormatter.java

@@ -36,6 +36,25 @@ public String getKey() {

    @Override
    public String format(String value) {
+        // Handle case names in order lastname, firstname and separated by ","


Sourround the new block with

if (!value.containts(" and ")) {

test also { as well as ;

For checking for Curly Braces there is a String Util Method which also has
a Unit Test. Maybe you can reuse that.

2016-06-03 14:13 GMT+02:00 Tobias Diez notifications@github.com:

In
src/main/java/net/sf/jabref/logic/formatter/bibtexfields/NormalizeNamesFormatter.java
#1470 (comment):

@@ -36,6 +36,25 @@ public String getKey() {

@Override public String format(String value) {

// Handle case names in order lastname, firstname and separated by ","

test also { as well as ;

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JabRef/jabref/pull/1470/files/efdced6ec231b82f0f8e82a32a57a2f0fb454fb7#r65697196,
or mute the thread
https://github.com/notifications/unsubscribe/AATi5PDxbzRee0GVpU2oQWEe35bpUgUMks5qIBpNgaJpZM4Is5D7
.

koppor · 2016-06-03T11:53:03Z

😮 - completely overseen that case. 🙈 - Thank you for clarifying!

@bruehldev Please include that test and fix the issue. I indicated the necessary change (check for value.containts(" and ")) at the appropriate place.

koppor · 2016-06-14T08:05:35Z

src/main/java/net/sf/jabref/logic/formatter/bibtexfields/NormalizeNamesFormatter.java

@@ -69,4 +105,15 @@ public String getExampleInput() {
        return "Albert Einstein and Alan Turing";
    }

+    private static boolean contains(final String[] array, final String[] searchTerms) {


Do not use arrays. Use Collections. Collections.contains is your friend.

Remove this unused method.

matthiasgeiger · 2016-06-20T08:06:33Z

Please check whether your improvement also solves #1504 by adding the example as an additional test case.

Thanks!

koppor · 2016-06-28T08:15:34Z

src/main/java/net/sf/jabref/logic/formatter/bibtexfields/NormalizeNamesFormatter.java

@@ -24,6 +30,9 @@
 */
 public class NormalizeNamesFormatter implements Formatter {

+    // Avoid partition where these values are contained
+    private final Collection<String> avoidTermsInLowerCase = Arrays.asList("jr", "sr", "jnr", "snr", "von", "zu", "van", "der");


Is "von", "zu", "van" also covered by test cases? My feeling is that the code might treat them wrong.

Why isn't this called "affixesInLowerCase"? - Why is "von", "zu", "van" and "der" an affix? I think, only jr, sr, jnr, and snr are affixes. - As far as I can guess, "van" are not affixes

When reading https://en.wikipedia.org/wiki/Suffix_(name), it seems that jr is a name suffix, isn't it?

Braunch · 2016-07-26T09:12:15Z

What is the status of this?

… format" Added the jr, sr,... special cases for semicolon partition. Fixed to avoid the "and", "{", ";" cases. Added Test for every case.

- Fix codacy issues

…rmated inputs

- Renamed value and valuePart variable - Edit comment - Exchanged for loop

Replaced for-loops with fancy util methods.

bruehldev · 2016-09-06T14:49:21Z

Rebased to upstream master. Should be ready to merge now

tobiasdiez · 2016-09-07T09:16:48Z

As far as I can see the new code is still in the NormalizeNamesFormatter. Please also add the cases mentioned in #1470 (comment) as tests for the AuthorList.parse method, i.e. as assertEqual(expectedAuthor, Authorlist.parse(...)). Thanks.
Ready-for-review removed until this is done.

bruehldev · 2016-09-08T13:50:18Z

@tobiasdiez sorry for the wrong statement. I thought it was pushed, From now on i will double check my uploaded code.

I added the test cases for semicolons. The standart format is already tested by threeAuthorsSeperatedByAnd, testMultipleNameAffixes, testNormalizeAuthorList. I hope it's okay that i'm using last2,3,4 and first2,3,4 as names in the semicolon test.

# Conflicts: # CHANGELOG.md

…#1470)

tschechlovdev added the stupro label Jun 2, 2016

stefan-kolb reviewed Jun 2, 2016
View reviewed changes

tobiasdiez added the stupro-ready-for-internal-review label Jun 2, 2016

stefan-kolb reviewed Jun 2, 2016
View reviewed changes

koppor reviewed Jun 3, 2016
View reviewed changes

koppor reviewed Jun 14, 2016
View reviewed changes

matthiasgeiger mentioned this pull request Jun 20, 2016

Normalize bibtex acts strangely #1504

Closed

bruehldev force-pushed the fix_1181 branch from e917719 to b28a926 Compare June 27, 2016 18:00

tschechlovdev changed the title ~~Fixed #1181: Improved "Normalize to BibTeX name format"~~ [WIP]Fixed #1181: Improved "Normalize to BibTeX name format" Jun 27, 2016

tschechlovdev removed the stupro-ready-for-internal-review label Jun 27, 2016

koppor reviewed Jun 28, 2016
View reviewed changes

koppor changed the title ~~[WIP]Fixed #1181: Improved "Normalize to BibTeX name format"~~ [WIP] Fixes #1181: Improved "Normalize to BibTeX name format" Jul 12, 2016

Braunch added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 3, 2016

bruehldev and others added 11 commits September 6, 2016 16:42

Fixes JabRef#1181 and JabRef#1504: Improved "Normalize to BibTeX name…

aaa2031

… format" Added the jr, sr,... special cases for semicolon partition. Fixed to avoid the "and", "{", ";" cases. Added Test for every case.

Added Tests for all avoiding Terms like der,zu,van,von,..

5f86b7b

- Corrected several comments

1f2dc65

- Fix codacy issues

Deleted method expectCorrect and insert assertEquals manually with fo…

8257118

…rmated inputs

Unnecessary use of fully qualified name fixed

e7ea5b6

Deleted unused import

0bdba77

QS processed

0253d2c

- Renamed value and valuePart variable - Edit comment - Exchanged for loop

Using Arrays.asList instead of Array.

bc55e0f

Replaced for-loops with fancy util methods.

Added test for upper case sensitve AND tests.

10ba1da

Corrected imports

4d07e24

Fixed wrong order of imports

d4b162f

bruehldev force-pushed the fix_1181 branch from 83686bf to d4b162f Compare September 6, 2016 14:46

tobiasdiez removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 7, 2016

Moved code to authorlist

56a8c89

Braunch added the stupro-ready-for-internal-review label Sep 8, 2016

Added tets for authors (semi-correct) seperated by semicolons.

104a41e

Merge remote-tracking branch 'upstream/master' into fix_1181

8516a92

# Conflicts: # CHANGELOG.md

bruehldev force-pushed the fix_1181 branch from a6ffc66 to 8516a92 Compare September 12, 2016 20:38

Add empty line

d6e3882

koppor removed the stupro-ready-for-internal-review label Sep 12, 2016

koppor changed the title ~~[WIP] Fixes #1181: Improved "Normalize to BibTeX name format"~~ Fixes #1181: Improved "Normalize to BibTeX name format" Sep 12, 2016

koppor mentioned this pull request Sep 12, 2016

"Normalize to BibTeX name format" should help when manually importing entries. #1181

Closed

koppor merged commit d9dc3a8 into JabRef:master Sep 12, 2016

koppor mentioned this pull request Oct 30, 2016

Author parser has problems with fetched bibtex author list #2205

Closed

zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016

Fixes JabRef#1181: Improved "Normalize to BibTeX name format" (JabRef…

05aaa71

…#1470)

tobiasdiez mentioned this pull request Mar 23, 2017

Fixed issue #2652 #2669

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #1181: Improved "Normalize to BibTeX name format" #1470

Fixes #1181: Improved "Normalize to BibTeX name format" #1470

bruehldev commented Jun 2, 2016 •

edited

Loading

koppor commented Jun 2, 2016

stefan-kolb commented Jun 2, 2016

stefan-kolb Jun 2, 2016

tobiasdiez commented Jun 2, 2016

stefan-kolb Jun 2, 2016 •

edited

Loading

koppor commented Jun 2, 2016

stefan-kolb commented Jun 3, 2016

tobiasdiez commented Jun 3, 2016

stefan-kolb commented Jun 3, 2016

koppor commented Jun 3, 2016

tobiasdiez commented Jun 3, 2016 •

edited

Loading

koppor Jun 3, 2016

tobiasdiez Jun 3, 2016

Siedlerchr Jun 3, 2016

koppor commented Jun 3, 2016 •

edited

Loading

koppor Jun 14, 2016

koppor Jul 26, 2016

matthiasgeiger commented Jun 20, 2016

koppor Jun 28, 2016

koppor Jul 26, 2016

Braunch commented Jul 26, 2016

bruehldev commented Sep 6, 2016

tobiasdiez commented Sep 7, 2016

bruehldev commented Sep 8, 2016

Fixes #1181: Improved "Normalize to BibTeX name format" #1470

Fixes #1181: Improved "Normalize to BibTeX name format" #1470

Conversation

bruehldev commented Jun 2, 2016 • edited Loading

koppor commented Jun 2, 2016

stefan-kolb commented Jun 2, 2016

Choose a reason for hiding this comment

tobiasdiez commented Jun 2, 2016

stefan-kolb Jun 2, 2016 • edited Loading

Choose a reason for hiding this comment

koppor commented Jun 2, 2016

stefan-kolb commented Jun 3, 2016

tobiasdiez commented Jun 3, 2016

stefan-kolb commented Jun 3, 2016

koppor commented Jun 3, 2016

tobiasdiez commented Jun 3, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor commented Jun 3, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthiasgeiger commented Jun 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Braunch commented Jul 26, 2016

bruehldev commented Sep 6, 2016

tobiasdiez commented Sep 7, 2016

bruehldev commented Sep 8, 2016

bruehldev commented Jun 2, 2016 •

edited

Loading

stefan-kolb Jun 2, 2016 •

edited

Loading

tobiasdiez commented Jun 3, 2016 •

edited

Loading

koppor commented Jun 3, 2016 •

edited

Loading