Entry Editor: "Other fields"

[ilippert]

current snap version on Fedora 30.

It seems to me that the algorithm that sorts what fields to show in the tab "other fields" is well identifying and showing those fields that are not default or optional.
The algorithm does not seem to check whether a "custom" field is displayed in another tab.

Use case: I have defined as general fields a field called "teachingmodule" and show that field in a separate tab. However, it is also shown in tab "other fields". The latter seems not clean.

[CyraxSector]

I'm working on this. Still in the analysis phase and get back with more information.

[Siedlerchr]

If you need any help with locating the issue or the code, just ask here or in gitter chat

[CyraxSector]

@Siedlerchr I've analysed the logic under EntryEditor.createTabs(). Hope I'm on the right path or is there any other place I should look at?

[tobiasdiez]

@CyraxSector That's the correct place to look at. In particular,

jabref/src/main/java/org/jabref/gui/entryeditor/OtherFieldsTab.java

Lines 33 to 43 in 47e3cc5

	protected Collection<String> determineFieldsToShow(BibEntry entry, EntryType entryType) {
	List<String> allKnownFields = entryType.getAllFields().stream().map(String::toLowerCase)
	.collect(Collectors.toList());
	List<String> otherFields = entry.getFieldNames().stream().map(String::toLowerCase)
	.filter(field -> !allKnownFields.contains(field)).collect(Collectors.toList());
	otherFields.removeAll(entryType.getDeprecatedFields());
	otherFields.remove(BibEntry.KEY_FIELD);
	otherFields.removeAll(customTabFieldNames);
	return otherFields;
	}

[CyraxSector]

@tobiasdiez Thanks. I'm carrying on the investigations

[CyraxSector]

PR #5056 is open for review

[Siedlerchr]

Thanks to @CyraxSector this issue should be fixed now.
The snap might take a bit longer to update