Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jlink task #5032

Merged
merged 1 commit into from
Jun 5, 2019
Merged

fix jlink task #5032

merged 1 commit into from
Jun 5, 2019

Conversation

siordache
Copy link
Contributor

@tobiasdiez
Copy link
Member

Thank you, very much appreciated! Is there a general approach to debug these kind of problems and to discover which modules to add to forceMerge (i.e. is there a similar statement as suggestMergedModuleInfo for mergedModule)?

@tobiasdiez tobiasdiez merged commit 3d92017 into JabRef:jdk9 Jun 5, 2019
@siordache
Copy link
Contributor Author

forceMerge is usually needed when some non-modular artifacts in your dependency graph use code that was previously part of the JDK but it was removed in the newer releases. The pom.xml associated with such a non-modular artifact does not mention that the artifact depends on the removed code (because the artifact was published when this code was still available in the JDK). That's why the plugin cannot detect all dependencies between artifacts in such situations.

This table shows the modules removed in JDK-11 and their replacements. When you find out that one of your non-modular dependencies requires code from one of these removed modules, you usually need to add the corresponding replacement library to your dependencies block and pass the prefix of the associated JAR file to forceMerge. Force-merging a library can create a cascading effect, so you may need to force-merge some additional artifacts.

I don't have a rigorous approach to find out which artifacts should be force-merged. Most of the time I just execute the jlink task and look for the module not found: ... error messages. Then I update the forceMerge calls and repeat the process. A couple of iterations are usually enough.

@siordache siordache deleted the jlink-issue61 branch April 18, 2020 16:47
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to RamonG92/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to dextep/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (#5040)
58d65fd Create cureus.csl (#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (#5041)
39a3fbb Create finance-and-society.csl (#5043)
cf39e19 Create canadian-biosystems-engineering-journal (#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (#5024)
776002d create new independent style for deutsches-arzteblatt.csl (#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (#5036)
13e0a0b Update iso690-full-note-cs.csl (#5033)
3af2034 Create acta-medica-peruana.csl (#5037)
dcbe494 Create historia-scribere.csl (#5038)
2174323 make addiction-biology.csl an AMA dependent (#5028)
b01aea8 Update ios-press-books.csl (#5030)
ae6d0e2 add doi for article-journal for ASA.csl (#5031)
d537025 Create organised-sound.csl (#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (#5026)
3dc5157 Update amerindia.csl (#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to graffaner/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants