Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Count shows the value of the other library #5327

Closed
Siedlerchr opened this issue Sep 17, 2019 · 8 comments · Fixed by #5328
Closed

Group Count shows the value of the other library #5327

Siedlerchr opened this issue Sep 17, 2019 · 8 comments · Fixed by #5328
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups ui

Comments

@Siedlerchr
Copy link
Member

master 1bec5ef Refs #5325 @tobiasdiez
Two libraries,
one with 16 entries, one with 2 entries.
All entries group shows always the value of the other library.
grafik

grafik
@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Sep 17, 2019
@tobiasdiez
Copy link
Member

Can you please debug and/or describe how to reproduce this issue... for me everything is working

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Sep 17, 2019 •
edited
Loading

Windows 10:
I just started the latest build from gradle with ./gradlew run
Two libs were opened at startup.

Using the version from the installer is the same problem.

  1. Start JabRef. Last two libraries are opened, focus is on the lib with 16 entries. No other group except the All entries group.
  2. Group count is 16
  3. Change to other library in tab , Group count is still 16
  4. Change back to to other libe: Group count is 2
  5. Always reproducible

@Siedlerchr
Copy link
Member Author

It appears to me that the wrong bibdatabasecontext is passed

@tobiasdiez
Copy link
Member

I cannot reproduce it on my two installations...

@Siedlerchr Siedlerchr mentioned this issue Sep 17, 2019
Closed
@AEgit
Copy link

AEgit commented Sep 17, 2019 •
edited
Loading

JabRef 5.0-dev--snapshot--2019-09-16--master--1bec5efd3
Windows 10 10.0 amd64
Java 11.0.4-bellsoft

Cannot reproduce the issue mentioned.
Note, that my setup differs in two (?relevant) points:

  1. Library 1 contains 6462 entries. Library 2 contains 4 entries.
  2. I have several groups in both libraries, not just the "All entries" group.

When I change from one library to the next, the correct entry count is shown in the "All entries" group. Note, however, that it takes a few seconds for library 1 to display the correct entry count. Every time I switch from library 2 to library 1, the entry count displayed in "All entries" is initially 0 and then jumps to 6462 entries. I reckon, JabRef always recalculates the number of entries when switching between the libraries. This behaviour will not be noticed if the libraries contain only a few entries, but with thousands of them you can notice the delay (which I personally do not mind).

tobiasdiez added a commit that referenced this issue Sep 17, 2019
@tobiasdiez
Improve group coloring and item count
5502659 
Fixes #5327. The problem was that `getTreeTableRow.getItem()` in `ViewModelTreeTableCellFactory` still returned the old item (and not the new one passed as method argument to `updateItem`).

 Since I was already looking at the code, this PR also fixes #3112 that improves the coloring after an entry was added to the group.
@tobiasdiez tobiasdiez mentioned this issue Sep 17, 2019
Merged
6 tasks
@tobiasdiez
Copy link
Member

Very nice observation @AEgit that the libraries had to have an empty groups tree in order to replicate this issue. With this I was able to fix the problem, and as a thank you also fixed a few other groups related issue you reported a while ago (see #5328).

@Siedlerchr
Copy link
Member Author

Can confirm it's fixed now!

@AEgit
Copy link

AEgit commented Sep 18, 2019

@tobiasdiez Cheers, thanks for the nice bugfixes!

koppor pushed a commit that referenced this issue Mar 29, 2021
Squashed 'buildres/csl/csl-styles/' changes from 30fb68e..e1acabe
3ca1b53 
e1acabe Upload Styles (#5351)
d9cbf08 Update and rename journal-of-eta-maritime-science.csl to dependent/journal-of-eta-maritime-science.csl (#5353)
988ecca Update clinical-and-translational-immunology.csl (#5348)
1691078 Update molecular-plant-pathology.csl (#5349)
932a5bf Create neurospine.csl (#5334)
d663ffc Update sylwan.csl (#5341)
b7be05d Update pakistan-journal-of-agricultural-sciences.csl (#5343)
d742832 Please rename to Tijdschrift-voor-geneeskunde-en-gezondheidszorg (#5344)
6c6be4d Update et-al settings for journal-of-the-american-society-of-nephrology.csl (#5333)
0263204 Correct citation format of numeric AOSIS styles (#5335)
e4cd348 Create the-horticulture-journal.csl (#5327)
5804a6f Add AOSIS dependents (#5332)
2b4510b Create natura-croatia.csl (#5328)
03c6789 Create groundwater.csl (#5329)
e08fa09 Create hystrix-the-italian-journal-of-mammalogy.csl (#5330)
1d730aa update page-range-format for Anglia (#5331)
9bb8724 Sort American Physiological Society citation style according to updated author instructions (#5305)
a8b53ca Create african-online-scientific-information-systems-vancouver.csl (#5326)
c7d8f90 Update yozgat-bozok-universitesi-fen-bilimleri-enstitusu.csl (#5319)
87dc0eb Update and rename tijdschrift-voor-geneeskunde.csl to tijdschrift-voo… (#5325)
89e07b0 Create university-of-gothenburg-apa7-swedish-legislations (#5316)
4582cb6 Create chinese-law-journals.csl (#5314)
6412083 Create stellenbosch-law-review.csl (#5322)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: e1acabe
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups ui
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve group coloring and item count JabRef/jabref
3 participants
@Siedlerchr @tobiasdiez @AEgit