Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: Add custom gradle plugin #5305

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Conversation

LyzardKing
Copy link
Collaborator

added a custom gradle plugin with the new build/run commands
added the gnome platform to use gtk3
added pycache to .gitignore to avoid committing python cache to git repo
Built locally jabref installs and runs (with limited testing...)
I imported my local library, and opened pdfs for now..
Do not merge yet since I need to still test adding the themes (I get some errors in the terminal, but it should be an easy fix)


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@LyzardKing
Copy link
Collaborator Author

@Siedlerchr @tobiasdiez
I added the integration with system themes (for the open/save dialogs, the rest is javafx stuff)
Everything seems to work on my system...but it needs testers to find all the possible issues.. let's find out all possible bugs ;)

@Siedlerchr
Copy link
Member

Thanks a lot, is this custom gradle plugin really necessary? From what I see you only added the base path?

@LyzardKing
Copy link
Collaborator Author

LyzardKing commented Sep 11, 2019

It is unfortunately, I had to remove the hardcoded "jar" argument for the gradle command.
I asked in the snapcraft forum if it's something that can be patched (without the custom plugin)
or if it'll be added (since java11 and modularity is a new thing...)
If this is changed then we can remove the custom plugin.
EDIT: we need to run "gradle jlink" and the plugin will only run "gradle jlink jar"

@LyzardKing
Copy link
Collaborator Author

@Siedlerchr I've opened a PR on snapcraft to add this functionality to the upstream plugin.
If for now you want to merge this it works (on my system...it whould work on the build system as well)
Then when I can get it merged upstream we can remove the custom version.

@Siedlerchr Siedlerchr merged commit 3184bce into JabRef:master Sep 11, 2019
@Siedlerchr
Copy link
Member

Okay I merged it, let's see if it works

koppor pushed a commit that referenced this pull request Mar 29, 2021
e1acabe Upload Styles (#5351)
d9cbf08 Update and rename journal-of-eta-maritime-science.csl to dependent/journal-of-eta-maritime-science.csl (#5353)
988ecca Update clinical-and-translational-immunology.csl (#5348)
1691078 Update molecular-plant-pathology.csl (#5349)
932a5bf Create neurospine.csl (#5334)
d663ffc Update sylwan.csl (#5341)
b7be05d Update pakistan-journal-of-agricultural-sciences.csl (#5343)
d742832 Please rename to Tijdschrift-voor-geneeskunde-en-gezondheidszorg (#5344)
6c6be4d Update et-al settings for journal-of-the-american-society-of-nephrology.csl (#5333)
0263204 Correct citation format of numeric AOSIS styles (#5335)
e4cd348 Create the-horticulture-journal.csl (#5327)
5804a6f Add AOSIS dependents (#5332)
2b4510b Create natura-croatia.csl (#5328)
03c6789 Create groundwater.csl (#5329)
e08fa09 Create hystrix-the-italian-journal-of-mammalogy.csl (#5330)
1d730aa update page-range-format for Anglia (#5331)
9bb8724 Sort American Physiological Society citation style according to updated author instructions (#5305)
a8b53ca Create african-online-scientific-information-systems-vancouver.csl (#5326)
c7d8f90 Update yozgat-bozok-universitesi-fen-bilimleri-enstitusu.csl (#5319)
87dc0eb Update and rename tijdschrift-voor-geneeskunde.csl to tijdschrift-voo… (#5325)
89e07b0 Create university-of-gothenburg-apa7-swedish-legislations (#5316)
4582cb6 Create chinese-law-journals.csl (#5314)
6412083 Create stellenbosch-law-review.csl (#5322)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: e1acabe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants