Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry preview parses html incorrectly after search with regular expression enabled #533

Closed
teertinker opened this issue Dec 17, 2015 · 6 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@teertinker
Copy link
Contributor

Jabref 3.0 as well as recent development versions do not parse the html code in the preview window correctly. This seems to happen if there is some html code WITHIN a certain bibtexfield. The citation is parsed correctly, but the "abstract" field in the preview window, which contains some autogenerated and manually inserted html code, seems to delete the "<" of each tag.
the string automatically inserted string "br>", appears the same way as my manual added italics "i>"

bildschirmfoto vom 2015-12-17 14 16 09
bildschirmfoto vom 2015-12-17 14 16 33

@matthiasgeiger
Copy link
Member

This is working fine for me.

I'm using the default entry preview setting with:
\begin{abstract}<BR><BR><b>Abstract: </b> \format[HTMLChars]{\abstract} \end{abstract}

Can you try this snippet in Options -> Preferences -> Entry Preview?

@teertinker
Copy link
Contributor Author

Thank you for your snippet. I was able to narrow down the problem... somehow. First your snippet changes nothing. There are, however some entries being parsed correctly, and some are parsed false.
After some digging I realized, that it is somehow connected with the new search function!

How to reproduce it:

  • look in your database for some entries with abstract with a certain keyword (e.g. "statistics")
    -> do NOT use the search function.
  • have a look at the abstracts, they are parsed correctly
  • enable "regular expression"
  • search for the key word e.g. "statistics"
  • look at the abstracts of your filtered entries -> they should be parsed incorrectly
  • clear the search term and unmark "regular expression"
  • go through your database.
    entries that have NOT been part of your filter, should be parsed correctly
    entries that were part of the filter are STILL parsed incorrectly

@teertinker teertinker changed the title Entry preview parses html incorrectly Entry preview parses html incorrectly after search with regular expression enabled Dec 17, 2015
@matthiasgeiger matthiasgeiger added the bug Confirmed bugs or reports that are very likely to be bugs label Dec 17, 2015
@matthiasgeiger
Copy link
Member

Thanks for digging into this.

I can reproduce the problem now.

@simonharrer
Copy link
Contributor

Please confirm that it is fixed by trying out the newest build containing the fix available at build.gradle.org in about 20 min.

@simonharrer simonharrer self-assigned this Dec 17, 2015
@teertinker
Copy link
Contributor Author

Thanks, it works now.

However, there is something new, that ist a bit irritating. The preview window for long entries (e.g. those with abstract) is now always scrolled to the bottom. So I can see the abstract, but not the reference. Therefore, to start reading, I have always to scroll to the top of the page. I don't know whether this is intended - it wasn't like this yesterday.

@simonharrer
Copy link
Contributor

Hm, yes, I see. Will revert this. Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

3 participants