Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlightning stops working when "regular expression" is active #565

Closed
koppor opened this issue Dec 21, 2015 · 2 comments
Closed

Highlightning stops working when "regular expression" is active #565

koppor opened this issue Dec 21, 2015 · 2 comments
Labels
status: help wanted type: enhancement

Comments

@koppor
Copy link
Member

koppor commented Dec 21, 2015

grabbed_20151221-235346

vs.

grabbed_20151221-235359

Refs #533
@stefan-kolb
Copy link
Member

@simonharrer I thought this is expected as we cannot really detect a match yet?!

@simonharrer
Copy link
Contributor

I was wrong. It could be implemented with existing methods relatively straight forward. Most things are already in place for this.

simonharrer added a commit that referenced this issue Dec 22, 2015
@simonharrer
Implements #565: Highlighting matches works now also for regular expr…
f680598 
…essions in preview panel and entry editor
simonharrer added a commit that referenced this issue Dec 22, 2015
@simonharrer
Implements #565: Highlighting matches works now also for regular expr…
0bc1810 
…essions in preview panel and entry editor
@koppor koppor closed this as completed Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonharrer @koppor @stefan-kolb