Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action "Import into current library" is active without any open library #5447

Closed
1 task done
b0n541 opened this issue Oct 14, 2019 · 5 comments · Fixed by #5448
Closed
1 task done

Action "Import into current library" is active without any open library #5447

b0n541 opened this issue Oct 14, 2019 · 5 comments · Fixed by #5448
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@b0n541
Copy link
Contributor

b0n541 commented Oct 14, 2019

JabRef version 5.0.0 (develop) on Ubuntu 18.04

Steps to reproduce the behavior:

  1. Start JabRef
  2. Choose menu File - Import - Import into current library
  3. Try to import some bib entries
  4. Alert dialog with NullPointerException is shown

Screenshot from 2019-10-14 21-57-20
@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Oct 14, 2019
@Siedlerchr Siedlerchr added this to the v5.0 milestone Oct 14, 2019
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. ui labels Oct 14, 2019
@Siedlerchr Siedlerchr removed this from the v5.0 milestone Oct 14, 2019
@Siedlerchr
Copy link
Member

The import into current library should be disabled if there is no library open

@b0n541
Copy link
Contributor Author

b0n541 commented Oct 14, 2019

Yes, I'll try to find a fix for that.

@tobiasdiez
Copy link
Member

jabref/src/main/java/org/jabref/gui/actions/ActionHelper.java

Lines 9 to 11 in d2ddff5

public static BooleanExpression needsDatabase(StateManager stateManager) {
return stateManager.activeDatabaseProperty().isPresent();
}

should be helpful

@b0n541
Copy link
Contributor Author

b0n541 commented Oct 14, 2019

Yes, I already found that one... :-D

@b0n541 b0n541 mentioned this issue Oct 14, 2019
Merged
6 tasks
tobiasdiez pushed a commit that referenced this issue Oct 15, 2019
@b0n541 @tobiasdiez
Fix nullpointer on import (#5448)
3bad538 
* Enable action "Import into current library" only if an open library exists #5447

* Add CHANGELOG entry #5447

* Fix checkstyle issue
@koppor
Copy link
Member

koppor commented Oct 15, 2019 •
edited
Loading

Refs #4795

@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nullpointer on import
4 participants
@Siedlerchr @koppor @b0n541 @tobiasdiez