Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullpointer on import #5448

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Fix nullpointer on import #5448

merged 3 commits into from
Oct 15, 2019

Conversation

b0n541
Copy link
Contributor

@b0n541 b0n541 commented Oct 14, 2019 •
edited by Siedlerchr
Loading

Fixes #5447

  • Change in CHANGELOG.md described
  • Tests created for changes
    --> not testable with unit tests
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
    --> not needed
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Siedlerchr
Siedlerchr approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, looks good to me

tobiasdiez
tobiasdiez approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks also from my side!

@tobiasdiez tobiasdiez merged commit 3bad538 into JabRef:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action "Import into current library" is active without any open library
3 participants
@b0n541 @Siedlerchr @tobiasdiez