Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching for a DOI results in an ERROR #5892

Closed
bernhard-kleine opened this issue Jan 29, 2020 · 2 comments · Fixed by #5938
Closed

Searching for a DOI results in an ERROR #5892

bernhard-kleine opened this issue Jan 29, 2020 · 2 comments · Fixed by #5938
Labels
entry-preview good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@bernhard-kleine
Copy link

bernhard-kleine commented Jan 29, 2020 •
edited
Loading

JabRef 5.0-beta.388--2020-01-29--eb988b6
Windows 7 6.1 amd64
Java 13.0.2

I searched in an empty library (in my standard library as well) for the DOI 10.1210/endrev/bnz006. This resulted in an error. In my opinion this a serious failure since a DOI should be searchable.

Log File 
ERROR FallbackExceptionHandler Uncaught exception occurred in Thread[JavaFX Application Thread,5,main]
netscape.javascript.JSException: SyntaxError: Invalid regular expression: missing )
     at org.jabref.merged.module/com.sun.webkit.dom.JSObject.fwkMakeException(Unknown Source)
     at org.jabref.merged.module/com.sun.webkit.WebPage.twkExecuteScript(Native Method)
     at org.jabref.merged.module/com.sun.webkit.WebPage.executeScript(Unknown Source)
     at org.jabref.merged.module/javafx.scene.web.WebEngine.executeScript(Unknown Source)
     at org.jabref/org.jabref.gui.preview.PreviewViewer.highlightSearchPattern(Unknown Source)
     at org.jabref/org.jabref.gui.preview.PreviewViewer.lambda$new$0(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.markInvalid(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.set(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectProperty.setValue(Unknown Source)
     at org.jabref/org.jabref.gui.StateManager.setSearchQuery(Unknown Source)
     at org.jabref/org.jabref.gui.search.GlobalSearchBar.performSearch(Unknown Source)
     at org.jabref/org.jabref.gui.search.GlobalSearchBar.lambda$new$8(Unknown Source)
     at org.jabref/org.jabref.gui.util.BindingsHelper$BidirectionalBinding.updateLocked(Unknown Source)
     at org.jabref/org.jabref.gui.util.BindingsHelper$BidirectionalBinding.changedB(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl$TextProperty.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl$TextProperty.markInvalid(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl$TextProperty.controlContentHasChanged(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl.lambda$new$0(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextField$TextFieldContent.insert(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl.replaceText(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl.updateContent(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl.replaceText(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl.replaceText(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl.replaceSelection(Unknown Source)
     at org.jabref.merged.module/javafx.scene.control.TextInputControl.paste(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.paste(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$new$20(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$keyMapping$62(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.scene.control.inputmap.InputMap.handle(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
     at org.jabref.merged.module/javafx.event.Event.fireEvent(Unknown Source)
     at org.jabref.merged.module/javafx.scene.Scene$KeyHandler.process(Unknown Source)
     at org.jabref.merged.module/javafx.scene.Scene.processKeyEvent(Unknown Source)
     at org.jabref.merged.module/javafx.scene.Scene$ScenePeerListener.keyEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(Unknown Source)
     at java.base/java.security.AccessController.doPrivileged(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleKeyEvent$1(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleKeyEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.glass.ui.View.handleKeyEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.glass.ui.View.notifyKey(Unknown Source)
     at org.jabref.merged.module/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
     at org.jabref.merged.module/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source)
     at java.base/java.lang.Thread.run(Unknown Source)
ERROR FallbackExceptionHandler Uncaught exception occurred in Thread[JavaFX Application Thread,5,main]
netscape.javascript.JSException: SyntaxError: Invalid regular expression: missing )
     at org.jabref.merged.module/com.sun.webkit.dom.JSObject.fwkMakeException(Unknown Source)
     at org.jabref.merged.module/com.sun.webkit.WebPage.twkExecuteScript(Native Method)
     at org.jabref.merged.module/com.sun.webkit.WebPage.executeScript(Unknown Source)
     at org.jabref.merged.module/javafx.scene.web.WebEngine.executeScript(Unknown Source)
     at org.jabref/org.jabref.gui.preview.PreviewViewer.highlightSearchPattern(Unknown Source)
     at org.jabref/org.jabref.gui.preview.PreviewViewer.lambda$new$0(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.fireValueChangedEvent(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.markInvalid(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.set(Unknown Source)
     at org.jabref.merged.module/javafx.beans.property.ObjectProperty.setValue(Unknown Source)
     at org.jabref/org.jabref.gui.StateManager.setSearchQuery(Unknown Source)
     at org.jabref/org.jabref.gui.search.GlobalSearchBar.performSearch(Unknown Source)
     at org.jabref.merged.module/org.reactfx.util.FxTimer.lambda$restart$0(Unknown Source)
     at org.jabref.merged.module/com.sun.scenario.animation.shared.TimelineClipCore.visitKeyFrame(Unknown Source)
     at org.jabref.merged.module/com.sun.scenario.animation.shared.TimelineClipCore.playTo(Unknown Source)
     at org.jabref.merged.module/javafx.animation.Timeline.doPlayTo(Unknown Source)
     at org.jabref.merged.module/javafx.animation.AnimationAccessorImpl.playTo(Unknown Source)
     at org.jabref.merged.module/com.sun.scenario.animation.shared.SingleLoopClipEnvelope.timePulse(Unknown Source)
     at org.jabref.merged.module/javafx.animation.Animation.doTimePulse(Unknown Source)
     at org.jabref.merged.module/javafx.animation.Animation$1.lambda$timePulse$0(Unknown Source)
     at java.base/java.security.AccessController.doPrivileged(Unknown Source)
     at org.jabref.merged.module/javafx.animation.Animation$1.timePulse(Unknown Source)
     at org.jabref.merged.module/com.sun.scenario.animation.AbstractMasterTimer.timePulseImpl(Unknown Source)
     at org.jabref.merged.module/com.sun.scenario.animation.AbstractMasterTimer$MainLoop.run(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(Unknown Source)
     at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(Unknown Source)
     at org.jabref.merged.module/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
     at org.jabref.merged.module/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
     at org.jabref.merged.module/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source)
     at java.base/java.lang.Thread.run(Unknown Source)
@tobiasdiez tobiasdiez added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 1, 2020
dawidm added a commit to dawidm/jabref that referenced this issue Feb 11, 2020
@dawidm
Fix not escaping special characters in search pattern
2f68520 
fixes JabRef#5892

* add method to get search pattern for searched words with escaped
 javascript regexp special characters (for search without regular
 expressions)

* in preview viewer use search pattern with escaped javascript regexp
 special characters
@dawidm dawidm mentioned this issue Feb 11, 2020
Merged
5 tasks
Siedlerchr pushed a commit that referenced this issue Feb 14, 2020
@dawidm
Fix not escaping special characters in search pattern (#5938)
ec93ad3 
* Fix not escaping special characters in search pattern

fixes #5892

* add method to get search pattern for searched words with escaped
 javascript regexp special characters (for search without regular
 expressions)

* in preview viewer use search pattern with escaped javascript regexp
 special characters

* Refactoring and performance improvement

* use enum to specify special characters escape mode

* use compiled regex pattern instead of string

* Refactoring: braces in if..else

* Refactoring, minor changes: names, comments

* Add tests of escaping special characters in search patterns
@Siedlerchr
Copy link
Member

Thanks to @dawidm this issue should be resolved now in the latest master.
It might take some time until the new version is uploaded.

@bernhard-kleine
Copy link
Author

I will test it tomorrow. 👍

koppor pushed a commit that referenced this issue Mar 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
927b7e7 
8f69d4e Container-title text-case set to title (#5931)
7200616 Create arrbhousestyle.csl (#5674)
8933609 Create hospital-a-domicilio.csl (#5924)
622bf63 Create international-journal-of-cosmetic-science.csl (#5886)
07e179f remove default-locale journal-de-la-societe-des-oceanistes.csl (#5887)
4435d1e update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5892)
18e547f Added fixes for steel-research-international.csl (#5921)
79e53a2 Update springer-basic-brackets-no-et-al.csl (#5925)
e4f411f Update antiquites-africaines.csl (#5923)
f4b3830 Create hemijska-industrija.csl (#5881)
1b33712 Create dhd.csl (#5920)
8462846 Update China national standard GB/T 7714 styles (#5860)
2c298be ISO formatted dates in sodertorns hogskola citation styles (#5882)
1114ec2 Update sodertorns-hogskola-oxford.csl (#5865)
20c439b Create boletin-de-la-sociedad-geologica-mexicana.csl (#5841)
e02b500 Create jurisprudence.csl (#5856)
a860c30 Update organization-studies.csl (#5914)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8f69d4e
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
entry-preview good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix not escaping special characters in search pattern dawidm/jabref
3 participants
@Siedlerchr @tobiasdiez @bernhard-kleine