-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix fetcher tests #5674
[WIP] Fix fetcher tests #5674
Conversation
Fix some wrong data Fix help pages Use jsoup for parsing pre content in inspire fetcher TODO: Find out why the bibtex parser does not work for the second and third returned entry
@@ -44,7 +44,7 @@ public void testGetName() { | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be OK for me to remove these kind of tests completely. Think, the have been introduced in 2015 by students to increase test coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be good
Nope, still some failing ones. https://travis-ci.org/JabRef/jabref/jobs/618489482?utm_medium=notification&utm_source=github_status |
I don't understand why the equals is failing: I don't see a differencec Edit: Debugging showed that PRIMARYCLASS is a standardfield argh!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we merge this now so that the changes to the actual fetcher are still included in the 5.0 beta release?
Yes, most things should be fixed. I will continue after the merge. |
I will just fix the ACS test then we can merge, the fetcher is broken |
…etchertest * 'fix+fetchertest' of github.com:JabRef/jabref: Update INSPIREFetcherTest.java Update GoogleScholarTest.java
8f69d4e Container-title text-case set to title (#5931) 7200616 Create arrbhousestyle.csl (#5674) 8933609 Create hospital-a-domicilio.csl (#5924) 622bf63 Create international-journal-of-cosmetic-science.csl (#5886) 07e179f remove default-locale journal-de-la-societe-des-oceanistes.csl (#5887) 4435d1e update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5892) 18e547f Added fixes for steel-research-international.csl (#5921) 79e53a2 Update springer-basic-brackets-no-et-al.csl (#5925) e4f411f Update antiquites-africaines.csl (#5923) f4b3830 Create hemijska-industrija.csl (#5881) 1b33712 Create dhd.csl (#5920) 8462846 Update China national standard GB/T 7714 styles (#5860) 2c298be ISO formatted dates in sodertorns hogskola citation styles (#5882) 1114ec2 Update sodertorns-hogskola-oxford.csl (#5865) 20c439b Create boletin-de-la-sociedad-geologica-mexicana.csl (#5841) e02b500 Create jurisprudence.csl (#5856) a860c30 Update organization-studies.csl (#5914) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 8f69d4e
Fix some wrong data
Fix help pages
Use jsoup for parsing pre content in inspire fetcher