Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix fetcher tests #5674

Merged
merged 13 commits into from
Nov 29, 2019
Merged

[WIP] Fix fetcher tests #5674

merged 13 commits into from
Nov 29, 2019

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Nov 26, 2019

Fix some wrong data
Fix help pages
Use jsoup for parsing pre content in inspire fetcher

Fix some wrong data
Fix help pages
Use jsoup for parsing pre content in inspire fetcher
TODO: Find out why the bibtex parser does not work for the second and third returned entry
@@ -44,7 +44,7 @@ public void testGetName() {

@Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be OK for me to remove these kind of tests completely. Think, the have been introduced in 2015 by students to increase test coverage.

Copy link
Member

@LinusDietz LinusDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be good

@Siedlerchr
Copy link
Member Author

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Nov 29, 2019

I don't understand why the equals is failing: I don't see a differencec

Edit: Debugging showed that PRIMARYCLASS is a standardfield argh!

org.opentest4j.AssertionFailedError: iterable contents differ at index [0], expected: 
org.jabref.model.entry.BibEntry@44a085e5<@phdthesis{Diez:2019pkg,
  archiveprefix = {arXiv},
  author = {Diez, Tobias},
  eprint = {1909.00744},
  primaryclass = {math.SG},
  reportnumber = {urn:nbn:de:bsz:15-qucosa2-352179},
  title = {Normal Form of Equivariant Maps and Singular Symplectic Reduction in Infinite Dimensions with Applications to Gauge Field Theory},
  year = {2019}
}> but was: org.jabref.model.entry.BibEntry@1a3e8e24<@phdthesis{Diez:2019pkg,
  archiveprefix = {arXiv},
  author = {Diez, Tobias},
  eprint = {1909.00744},
  primaryclass = {math.SG},
  reportnumber = {urn:nbn:de:bsz:15-qucosa2-352179},
  title = {Normal Form of Equivariant Maps and Singular Symplectic Reduction in Infinite Dimensions with Applications to Gauge Field Theory},
  year = {2019}
}>

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we merge this now so that the changes to the actual fetcher are still included in the 5.0 beta release?

@Siedlerchr
Copy link
Member Author

Yes, most things should be fixed. I will continue after the merge.

@Siedlerchr
Copy link
Member Author

I will just fix the ACS test then we can merge, the fetcher is broken

…etchertest

* 'fix+fetchertest' of github.com:JabRef/jabref:
  Update INSPIREFetcherTest.java
  Update GoogleScholarTest.java
@Siedlerchr Siedlerchr merged commit f9cf996 into master Nov 29, 2019
@Siedlerchr Siedlerchr deleted the fix+fetchertest branch November 29, 2019 15:42
koppor pushed a commit that referenced this pull request Mar 1, 2022
8f69d4e Container-title text-case set to title (#5931)
7200616 Create arrbhousestyle.csl (#5674)
8933609 Create hospital-a-domicilio.csl (#5924)
622bf63 Create international-journal-of-cosmetic-science.csl (#5886)
07e179f remove default-locale journal-de-la-societe-des-oceanistes.csl (#5887)
4435d1e update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5892)
18e547f Added fixes for steel-research-international.csl (#5921)
79e53a2 Update springer-basic-brackets-no-et-al.csl (#5925)
e4f411f Update antiquites-africaines.csl (#5923)
f4b3830 Create hemijska-industrija.csl (#5881)
1b33712 Create dhd.csl (#5920)
8462846 Update China national standard GB/T 7714 styles (#5860)
2c298be ISO formatted dates in sodertorns hogskola citation styles (#5882)
1114ec2 Update sodertorns-hogskola-oxford.csl (#5865)
20c439b Create boletin-de-la-sociedad-geologica-mexicana.csl (#5841)
e02b500 Create jurisprudence.csl (#5856)
a860c30 Update organization-studies.csl (#5914)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8f69d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants