Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group is lost if assigned to very bottom #5968

Closed
1 task done
Ka0o0 opened this issue Feb 20, 2020 · 2 comments · Fixed by #5983
Closed
1 task done

Group is lost if assigned to very bottom #5968

Ka0o0 opened this issue Feb 20, 2020 · 2 comments · Fixed by #5983

Comments

@Ka0o0
Copy link
Contributor

Ka0o0 commented Feb 20, 2020

JabRef version (latest master) on macOS 10.15.3, Java 13.0.1

  • I have tested the latest master

Steps to reproduce the behavior:

  1. Drag and Drop a group at the very bottom.
  2. Exception is shown and group is lost
Log File 
java.lang.IndexOutOfBoundsException: Index: 2, Size: 1
  at java.base/java.util.ArrayList.rangeCheckForAdd(ArrayList.java:754)
  at java.base/java.util.ArrayList.add(ArrayList.java:479)
  at javafx.base/com.sun.javafx.collections.ObservableListWrapper.doAdd(ObservableListWrapper.java:101)
  at javafx.base/javafx.collections.ModifiableObservableListBase.add(ModifiableObservableListBase.java:151)
  at org.jabref/org.jabref.model.TreeNode.addChild(TreeNode.java:474)
  at org.jabref/org.jabref.model.TreeNode.moveTo(TreeNode.java:562)
  at org.jabref/org.jabref.gui.groups.GroupNodeViewModel.moveTo(GroupNodeViewModel.java:286)
  at org.jabref/org.jabref.gui.groups.GroupNodeViewModel.draggedOn(GroupNodeViewModel.java:312)
  at org.jabref/org.jabref.gui.groups.GroupTreeView.lambda$initialize$15(GroupTreeView.java:244)
  at javafx.base/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
  at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238)
  at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
  at javafx.base/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
  at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
  at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
  at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
  at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
  at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
  at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
  at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
  at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
  at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
  at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
  at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
  at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
  at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
  at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
  at javafx.base/com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
  at javafx.base/com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
  at javafx.base/javafx.event.Event.fireEvent(Event.java:198)
  at javafx.graphics/javafx.scene.Scene$DnDGesture.fireEvent(Scene.java:3029)
  at javafx.graphics/javafx.scene.Scene$DnDGesture.processTargetDrop(Scene.java:3255)
  at javafx.graphics/javafx.scene.Scene$DropTargetListener.drop(Scene.java:2969)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassSceneDnDEventHandler.lambda$handleDragDrop$2(GlassSceneDnDEventHandler.java:108)
  at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassSceneDnDEventHandler.handleDragDrop(GlassSceneDnDEventHandler.java:104)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleDragDrop$11(GlassViewEventHandler.java:766)
  at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:412)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleDragDrop(GlassViewEventHandler.java:765)
  at javafx.graphics/com.sun.glass.ui.View.handleDragDrop(View.java:713)
  at javafx.graphics/com.sun.glass.ui.View.notifyDragDrop(View.java:1042)
  at javafx.graphics/com.sun.glass.ui.mac.MacPasteboard._putItemsFromArray(Native Method)
  at javafx.graphics/com.sun.glass.ui.mac.MacPasteboard.putItemsFromArray(MacPasteboard.java:143)
  at javafx.graphics/com.sun.glass.ui.mac.MacPasteboard.putItems(MacPasteboard.java:165)
  at javafx.graphics/com.sun.glass.ui.mac.MacSystemClipboard.pushToSystem(MacSystemClipboard.java:223)
  at javafx.graphics/com.sun.glass.ui.SystemClipboard.flush(SystemClipboard.java:51)
  at javafx.graphics/com.sun.glass.ui.ClipboardAssistance.flush(ClipboardAssistance.java:59)
  at javafx.graphics/com.sun.javafx.tk.quantum.QuantumClipboard.flush(QuantumClipboard.java:274)
  at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.startDrag(QuantumToolkit.java:1286)
  at javafx.graphics/javafx.scene.Scene$DnDGesture.dragDetectedProcessed(Scene.java:3049)
  at javafx.graphics/javafx.scene.Scene$DnDGesture.process(Scene.java:3118)
  at javafx.graphics/javafx.scene.Scene$MouseHandler.process(Scene.java:3878)
  at javafx.graphics/javafx.scene.Scene.processMouseEvent(Scene.java:1849)
  at javafx.graphics/javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2590)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:409)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:299)
  at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(GlassViewEventHandler.java:447)
  at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:412)
  at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:446)
  at javafx.graphics/com.sun.glass.ui.View.handleMouseEvent(View.java:556)
  at javafx.graphics/com.sun.glass.ui.View.notifyMouse(View.java:942)
  at javafx.graphics/com.sun.glass.ui.mac.MacView.notifyMouse(MacView.java:127)
@calixtus
Copy link
Member

Thanks for the issue. To be a bit more precise:
1.a. Grab a group at the very bottom and
1.b. Drop it at the very bottom.
Or did I miss some other misbehaving?
I'm on it.

@calixtus calixtus mentioned this issue Feb 21, 2020
Merged
5 tasks
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

koppor pushed a commit that referenced this issue Apr 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177
21de2bf 
21e2177 Create respiratory-care-journal.csl (#5998)
d0a2846 Update archaeonautica.csl (#5987)
664784e Update cardiff-university-harvard.csl (#5982)
07ce91e improve journal-of-avian-biology.csl (#5984)
349a5d6 update based on latest version of ISO 690 standard (#5976)
d8c3725 Update mary-ann-liebert-vancouver.csl (#5981)
7b2e70d Update style-manual-australian-government.csl (#5975)
bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979)
cabcdd4 Update united-states-international-trade-commission.csl (#5967)
948c48a Update cardiff-university-harvard.csl (#5977)
d6bf535 Add name to label gun
cf0d930 Test label gun
2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964)
aa023e1 Create materials-research-society-bulletin.csl (#5917)
ea31783 Changed quotation marks to Spanish ones (#5968)
27245f9 AJA: Add "." suffix to citation layout. (#5971)
7726a40 Update american-medical-association.csl (#5970)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 21e2177
Siedlerchr pushed a commit that referenced this issue Apr 1, 2022
@koppor
Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632
c4d01bf 
)

21e2177 Create respiratory-care-journal.csl (#5998)
d0a2846 Update archaeonautica.csl (#5987)
664784e Update cardiff-university-harvard.csl (#5982)
07ce91e improve journal-of-avian-biology.csl (#5984)
349a5d6 update based on latest version of ISO 690 standard (#5976)
d8c3725 Update mary-ann-liebert-vancouver.csl (#5981)
7b2e70d Update style-manual-australian-government.csl (#5975)
bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979)
cabcdd4 Update united-states-international-trade-commission.csl (#5967)
948c48a Update cardiff-university-harvard.csl (#5977)
d6bf535 Add name to label gun
cf0d930 Test label gun
2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964)
aa023e1 Create materials-research-society-bulletin.csl (#5917)
ea31783 Changed quotation marks to Spanish ones (#5968)
27245f9 AJA: Add "." suffix to citation layout. (#5971)
7726a40 Update american-medical-association.csl (#5970)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 21e2177

Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>
koppor pushed a commit that referenced this issue Apr 15, 2022
Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..9ff3112
9d994ae 
9ff3112 Update bibtex.csl (#6021)
68ed5f7 Don't initialize with hyphen in Vancouver/NLM (#6022)
80206ad Update american-physics-society.csl (#5934)
cfbdba6 Update csl style (#6003)
546ee88 Update institut-francais-darcheologie-orientale-en.csl (#6018)
1153e3e Update institut-francais-darcheologie-orientale-etudes-arabes.csl (#6019)
42d5031 Update institut-francais-darcheologie-orientale-arab-studies.csl (#6020)
2e10c7a Update institut-francais-darcheologie-orientale.csl (#6015)
0c7d6a1 Create science-china-materials.csl (#6017)
0eb4bc7 Update frontiers.csl (#6014)
0fd9cc2 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5963)
1393837 Update harvard-university-of-the-west-of-england.csl (#6013)
4474b0e Update frontiers-of-biogeography.csl (#6010)
736c6df Render status field (for forthcoming, in press, etc.) to date groups (#6005)
51ff3dc Create journal-of-contemporary-water-research-and-education.csl (#5912)
7387ed3 cell.csl: Add a macro for DOI and webpage accessed date. (#5999)
21e2177 Create respiratory-care-journal.csl (#5998)
d0a2846 Update archaeonautica.csl (#5987)
664784e Update cardiff-university-harvard.csl (#5982)
07ce91e improve journal-of-avian-biology.csl (#5984)
349a5d6 update based on latest version of ISO 690 standard (#5976)
d8c3725 Update mary-ann-liebert-vancouver.csl (#5981)
7b2e70d Update style-manual-australian-government.csl (#5975)
bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979)
cabcdd4 Update united-states-international-trade-commission.csl (#5967)
948c48a Update cardiff-university-harvard.csl (#5977)
d6bf535 Add name to label gun
cf0d930 Test label gun
2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964)
aa023e1 Create materials-research-society-bulletin.csl (#5917)
ea31783 Changed quotation marks to Spanish ones (#5968)
27245f9 AJA: Add "." suffix to citation layout. (#5971)
7726a40 Update american-medical-association.csl (#5970)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 9ff3112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed loosing group if the most bottom one in list is dragged on itself calixtus/jabref
3 participants
@Ka0o0 @tobiasdiez @calixtus