Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog "Customize Entry Types" - drag&drop not working - adding new field buggy #6338

Closed
ElisEck opened this issue Apr 24, 2020 · 8 comments · Fixed by #6152 or #8121
Closed

Dialog "Customize Entry Types" - drag&drop not working - adding new field buggy #6338

ElisEck opened this issue Apr 24, 2020 · 8 comments · Fixed by #6152 or #8121
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@ElisEck
Copy link

ElisEck commented Apr 24, 2020

Luckily the "Customize Entry Types"-Dialog ist back! Unfortunately it is not (yet) working thoroughly:

  • the "plus"-button for fields is grey and can therefore not be pressed, although I have entered a fieldname in the dropdown-box - this only changes after one clicks into the "new entry type"-box at least once
  • the drag and drop to change the order isn't working at all (or at least I cannot figure out where to touch the line to drag&drop)

I have experienced this using:
JabRef 5.0--2020-03-06--2e6f433
Windows 10 10.0 amd64
Java 13.0.2

I have tested the latest development version and the problem persists:
JabRef 5.1--2020-04-23--bbea7df
Windows 10 10.0 amd64
Java 14.0.1

@ElisEck ElisEck changed the title Dialog "Customize Entry Types" - several issues Dialog "Customize Entry Types" - drag&drop not working - adding new field buggy Apr 24, 2020
@Siedlerchr
Copy link
Member

Refs #6152

@domhardt
Copy link

I can reproduce this problem. Additionally I'm not able to delete entry types (left half of the "Customize Entry Types" dialog). They are back as soon as I reopen the dialog.

JabRef 5.0--2020-03-06--2e6f433
Mac OS X 10.14.6 x86_64
Java 13.0.2

Bildschirmfoto 2020-04-24 um 12 27 59

@Siedlerchr
Copy link
Member

Yes, this is known and I started working on it (see linked PR, but turned out it's complicated).
Second, you can't delete StandardEntryTypes atm. Maybe needs a "reset to default button".

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Apr 24, 2020
@Siedlerchr
Copy link
Member

@domhardt @ElisEck

You can now use drag and drop to reorder to the fields. The order is now also reflected in the entry editor.
You can't delete the Standard Entry Types. They will be re added upon reopening the dialog. That's actually a safety measure to prevent accidental breaking of JabRef.

The new version (currently building) will be available at
https://builds.jabref.org/master/

@ElisEck
Copy link
Author

ElisEck commented Jul 3, 2020

@Siedlerchr Tank you so much, works quite well!

@wujastyk
Copy link

wujastyk commented Oct 4, 2021

JabRef 5.4--2021-10-04--5a1b936
Linux 5.11.0-37-generic amd64
Java 16.0.2
JavaFX 17+18

Dragging and dropping fields to get the right order for the entry editor is driving me mad. One can't "insert" a field between two others. Moving a field swaps it's value with the other field. So one ends up doing a kind of bubble-sort in one's brain. It's awful :-)

This is a feature request, not a bug. Please allow the drag-n-drop to insert a field between two others.

image

@Siedlerchr Siedlerchr reopened this Oct 4, 2021
Siedlerchr added a commit that referenced this issue Oct 4, 2021
@Siedlerchr
Copy link
Member

@wujastyk Can you please test this version? I improved the DnD https://builds.jabref.org/pull/8121/merge/
(just needs some more visual clues, but works when you drop in between)

@wujastyk
Copy link

wujastyk commented Oct 5, 2021

Yes, it works. This is super. Thank you so much; I can now leave the asylum and resume normal life :-)

koppor pushed a commit that referenced this issue Dec 17, 2022
84dba23 Update international-union-of-crystallography.csl (#6279)
13dd9e8 Update zeitschrift-fur-deutsche-philologie.csl (#6340)
d95b652 Create cahiers-mondes-anciens.csl (#6203)
ded567c Create rassegna-degli-archivi-di-stato-bibliografia-generale.csl (#6275)
124777a Create scientific-online-letters-on-the-atmosphere.csl (#6261)
3c276e7 Create american-medical-association-no-url-alphabetical.csl (#6252)
595ad95 Bump mathieudutour/github-tag-action from 6.0 to 6.1 (#6287)
7008128 Create cambridge-a (#6336)
17e930c Update norsk-apa-manual-note.csl (#6338)
b360859 Update norsk-apa-manual.csl (#6337)
f6c778e Update emerald-harvard.csl (#6335)
d6c6a16 Fix Brazilian quotes on  chicago-author-date.csl (#6317)
a1549b6 Update medizinische-hochschule-hannover.csl (#6330)
da88073 Update journal-of-the-american-college-of-cardiology.csl (#6334)
a520d8e Bump nokogiri from 1.13.9 to 1.13.10 (#6333)
ba54b44 Update royal-society-of-chemistry.csl (#6328)
1378ba7 LUSEM: Remove full stop (#6332)
9e3cf89 Create interpreting.csl (#6254)
bef74ed Create conservation-science-and-practice.csl (#6258)
9fb7eb7 Bug fixes triangle.csl (#6251)
e6112ba Update ucl-university-college-apa.csl (#6250)
6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247)
00fe4a2 Create constructivist-foundations.csl (#6243)
03ad71b Create les-mondes-du-travail.csl (#6234)
a2bce86 Corrections based on author instructions (#6306)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 84dba23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
Archived in project
4 participants