Allow reordering of custom entry types fields

[Siedlerchr]

Additionally, restore the old Multiline Property and make it configurable.

Current status:

• Adding/Removing/Reordering works

• Removing standard entry types has no effect (they are always readded if deleted

• Sort fields alphabetically? Would that effect the order? Needs investigation
  ==> cannot sort. it influences the save order

Refs #5230 and #4373

Fixes #6338

• Change in CHANGELOG.md described (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for bigger UI changes)
• Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

[Siedlerchr]

LinkedHashSet is no solution either, as the standard fields are always inserted first.
TODO check it again

[Siedlerchr]

@tobiasdiez I currently have the problems that in my HashMap which contains entry types with their corresponding fields, the fields order is not updated if I change them via drag and drop in the main table.
This is logical, because the fieldsWithTypes is not an Observable.
Any idea how I can do this with some Binding Foo? Can I add some ObservabeList to that map?

https://github.com/JabRef/jabref/pull/6152/files#diff-8313b29670cb7c9bc50c020e1b2b5f17L80-R101

[tobiasdiez]

I'm not sure what exactly you mean. A Map<EntryType, ObservableList<Field>> does not work?

[Siedlerchr]

I tired it, but its a bit more complicated I think (Or maybe I am thinking too complicated)

I would need to bind a ListProperty to the values Collection of my map
and then I would need to change that ListProperty (fieldsForType) content based on my selected entry types. Currently I am doing this more or less manually.

    private final ListProperty<FieldViewModel> fieldsForType;

    private final ObservableList<FieldViewModel> allFieldsForType = FXCollections.observableArrayList(extractor -> new Observable[] {extractor.fieldName(), extractor.fieldType()});

      for (BibEntryType entryType : allTypes) {
            List<FieldViewModel> fields = entryType.getAllFields().stream().map(bibField -> new FieldViewModel(bibField.getField(), entryType.isRequired(bibField.getField()), bibField.getPriority(), entryType)).collect(Collectors.toList());
            typesWithFields.put(entryType, FXCollections.observableArrayList(fields));
        }
        

        this.fieldsForType = new SimpleListProperty<>(allFieldsForType);

        EasyBind.subscribe(selectedEntryTypes, type -> {
            if (type != null) {
                allFieldsForType.setAll(typesWithFields.get(type));
            }
        });

[tobiasdiez]

I guess the following might work:

• Create your Map<EntryType, ObservableList<Fields>> entryTypesWithFields.
• When the user selects an entryType then set fieldsForType to entryTypesWithFields.get(entryType). It is important that you set really the observable list and not the contents of the list (i.e. not setAll).

By the way, the whole map construction seems to be overly complicated. Why not create a EntryTypeViewModel that wraps a given entry type and also contains an observable list of fields. Then you can have a simple observable list of EntryTypeViewModels, which you can bind to the list and then bind the contents of the field list to the observable list of the current entry type.

[koppor]

This PR looks finished and looks awesome!

Nevertheless, I have some comments...

[Siedlerchr]

TODO:

1. Modify type article, add field langid
2. Make optional
3. Move after number
4. Save
5. Reopen dialog
   => langid field is no longer after number, it has moved to a different position

Problem possible: in BibEntryTypesManager;

   public SortedSet<BibEntryType> getAllTypes() {
            SortedSet<BibEntryType> allTypes = new TreeSet<>(customOrModifiedType);
            allTypes.addAll(standardTypes);
            return allTypes;
        }

[Siedlerchr]

Yeah! I found the bug:
Custom Entry types order is now correctly stored and also applied to entry editor!