Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch InaccessibleObjectException #6519

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

systemoperator
Copy link
Contributor

@systemoperator systemoperator commented May 24, 2020

Catch InaccessibleObjectException otherwise JabRef becomes unusable in some occasions.

The problem is hard to reproduce, but happens quite frequently. It seems to be caused in the combination of searching the main table with the search bar and then clicking on a defined group in the side panel, where apparently some tooltip wants to get displayed during this processes (which I think is not vital in this case).

With this fix, I don't observe any malfunction and JabRef keeps usable. Since quite a lot other exceptions are already caught there, I think adding this one as well could be feasible.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.
Stack trace

22:51:38.624 [JavaFX Application Thread] ERROR org.jabref.FallbackExceptionHandler - Uncaught exception occurred in Thread[JavaFX Application Thread,5,main]
java.lang.reflect.InaccessibleObjectException: Unable to make protected javafx.scene.control.Label com.sun.javafx.scene.control.ContextMenuContent$MenuItemContainer.getLabel() accessible: module javafx.controls does not "opens com.sun.javafx.scene.control" to module org.jabref
at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:349) ~[?:?]
at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:289) ~[?:?]
at java.lang.reflect.Method.checkCanSetAccessible(Method.java:196) ~[?:?]
at java.lang.reflect.Method.setAccessible(Method.java:190) ~[?:?]
at org.jabref.gui.actions.ActionFactory.getAssociatedNode(ActionFactory.java:67) ~[classes/:?]
at org.jabref.gui.actions.ActionFactory.lambda$configureMenuItem$1(ActionFactory.java:85) ~[classes/:?]
at com.tobiasdiez.easybind.EasyBind.lambda$subscribe$2(EasyBind.java:481) ~[easybind-2.0.0-SNAPSHOT.jar:?]
at com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:360) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ReadOnlyStringPropertyBase.fireValueChangedEvent(ReadOnlyStringPropertyBase.java:72) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ReadOnlyStringWrapper.fireValueChangedEvent(ReadOnlyStringWrapper.java:103) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.StringPropertyBase.markInvalid(StringPropertyBase.java:111) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.StringPropertyBase$Listener.invalidated(StringPropertyBase.java:231) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) ~[javafx-base-14-linux.jar:?]
at javafx.beans.binding.ObjectBinding.invalidate(ObjectBinding.java:170) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.BindingHelperObserver.invalidated(BindingHelperObserver.java:52) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.BooleanPropertyBase.fireValueChangedEvent(BooleanPropertyBase.java:104) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ReadOnlyBooleanWrapper.fireValueChangedEvent(ReadOnlyBooleanWrapper.java:101) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:111) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.BooleanPropertyBase$Listener.invalidated(BooleanPropertyBase.java:239) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) ~[javafx-base-14-linux.jar:?]
at javafx.beans.binding.BooleanBinding.invalidate(BooleanBinding.java:174) ~[javafx-base-14-linux.jar:?]
at javafx.beans.binding.Bindings$ShortCircuitAndInvalidator.invalidated(Bindings.java:4622) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) ~[javafx-base-14-linux.jar:?]
at javafx.beans.binding.BooleanBinding.invalidate(BooleanBinding.java:174) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.BindingHelperObserver.invalidated(BindingHelperObserver.java:52) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:321) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ModifiableObservableListBase.setAll(ModifiableObservableListBase.java:90) ~[javafx-base-14-linux.jar:?]
at org.jabref.gui.StateManager.setSelectedEntries(StateManager.java:93) ~[classes/:?]
at org.jabref.gui.BasePanel.lambda$createMainTable$1(BasePanel.java:290) ~[classes/:?]
at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.scene.control.SelectedItemsReadOnlyObservableList.lambda$new$1(SelectedItemsReadOnlyObservableList.java:103) ~[javafx-controls-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.scene.control.ReadOnlyUnbackedObservableList._endChange(ReadOnlyUnbackedObservableList.java:64) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.MultipleSelectionModelBase$SelectedIndicesList._endChange(MultipleSelectionModelBase.java:896) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.ControlUtils.updateSelectedIndices(ControlUtils.java:202) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.TableView$TableViewArrayListSelectionModel.fireCustomSelectedCellsListChangeEvent(TableView.java:3027) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.TableView$TableViewArrayListSelectionModel.clearSelection(TableView.java:2803) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.TableView$TableViewArrayListSelectionModel.updateDefaultSelection(TableView.java:2992) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.TableView$TableViewArrayListSelectionModel.lambda$new$2(TableView.java:2182) ~[javafx-controls-14-linux.jar:?]
at javafx.collections.WeakListChangeListener.onChanged(WeakListChangeListener.java:88) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.transformation.SortedList.sourceChanged(SortedList.java:114) ~[javafx-base-14-linux.jar:?]
at javafx.collections.transformation.TransformationList.lambda$getListener$0(TransformationList.java:106) ~[javafx-base-14-linux.jar:?]
at javafx.collections.WeakListChangeListener.onChanged(WeakListChangeListener.java:88) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.transformation.FilteredList.refilter(FilteredList.java:338) ~[javafx-base-14-linux.jar:?]
at javafx.collections.transformation.FilteredList$1.invalidated(FilteredList.java:102) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ObjectPropertyBase.markInvalid(ObjectPropertyBase.java:112) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ObjectPropertyBase$Listener.invalidated(ObjectPropertyBase.java:234) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) ~[javafx-base-14-linux.jar:?]
at javafx.beans.binding.ObjectBinding.invalidate(ObjectBinding.java:170) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.BindingHelperObserver.invalidated(BindingHelperObserver.java:52) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ListExpressionHelper$Generic.notifyListeners(ListExpressionHelper.java:584) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ListExpressionHelper$Generic.fireValueChangedEvent(ListExpressionHelper.java:548) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ListExpressionHelper.fireValueChangedEvent(ListExpressionHelper.java:103) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ReadOnlyListPropertyBase.fireValueChangedEvent(ReadOnlyListPropertyBase.java:88) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ReadOnlyListWrapper.fireValueChangedEvent(ReadOnlyListWrapper.java:106) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ListPropertyBase.markInvalid(ListPropertyBase.java:221) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ListPropertyBase$Listener.invalidated(ListPropertyBase.java:336) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) ~[javafx-base-14-linux.jar:?]
at javafx.beans.binding.ObjectBinding.invalidate(ObjectBinding.java:170) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.BindingHelperObserver.invalidated(BindingHelperObserver.java:52) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.MapListenerHelper$SingleInvalidation.fireValueChangedEvent(MapListenerHelper.java:125) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.MapListenerHelper.fireValueChangedEvent(MapListenerHelper.java:72) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ObservableMapWrapper.callObservers(ObservableMapWrapper.java:115) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ObservableMapWrapper.put(ObservableMapWrapper.java:169) ~[javafx-base-14-linux.jar:?]
at org.jabref.gui.StateManager.setSelectedGroups(StateManager.java:98) ~[classes/:?]
at org.jabref.gui.groups.GroupTreeViewModel.lambda$onSelectedGroupChanged$3(GroupTreeViewModel.java:103) ~[classes/:?]
at java.util.Optional.ifPresent(Optional.java:176) ~[?:?]
at org.jabref.gui.groups.GroupTreeViewModel.onSelectedGroupChanged(GroupTreeViewModel.java:99) ~[classes/:?]
at com.tobiasdiez.easybind.EasyBind.lambda$subscribe$2(EasyBind.java:481) ~[easybind-2.0.0-SNAPSHOT.jar:?]
at com.sun.javafx.binding.ListExpressionHelper$Generic.notifyListeners(ListExpressionHelper.java:588) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ListExpressionHelper$Generic.fireValueChangedEvent(ListExpressionHelper.java:571) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.binding.ListExpressionHelper.fireValueChangedEvent(ListExpressionHelper.java:109) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ListPropertyBase.fireValueChangedEvent(ListPropertyBase.java:201) ~[javafx-base-14-linux.jar:?]
at javafx.beans.property.ListPropertyBase.lambda$new$0(ListPropertyBase.java:57) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper$SingleChange.fireValueChangedEvent(ListListenerHelper.java:164) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ModifiableObservableListBase.setAll(ModifiableObservableListBase.java:90) ~[javafx-base-14-linux.jar:?]
at javafx.beans.binding.ListExpression.setAll(ListExpression.java:372) ~[javafx-base-14-linux.jar:?]
at org.jabref.gui.groups.GroupTreeView.updateSelection(GroupTreeView.java:279) ~[classes/:?]
at org.jabref.gui.util.BindingsHelper$BidirectionalListBinding.onChanged(BindingsHelper.java:271) ~[classes/:?]
at com.sun.javafx.collections.ListListenerHelper$SingleChange.fireValueChangedEvent(ListListenerHelper.java:164) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.scene.control.SelectedItemsReadOnlyObservableList.lambda$new$1(SelectedItemsReadOnlyObservableList.java:103) ~[javafx-controls-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541) ~[javafx-base-14-linux.jar:?]
at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.scene.control.ReadOnlyUnbackedObservableList._endChange(ReadOnlyUnbackedObservableList.java:64) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.MultipleSelectionModelBase$SelectedIndicesList._endChange(MultipleSelectionModelBase.java:896) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.ControlUtils.updateSelectedIndices(ControlUtils.java:202) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.TreeTableView$TreeTableViewArrayListSelectionModel.fireCustomSelectedCellsListChangeEvent(TreeTableView.java:3361) ~[javafx-controls-14-linux.jar:?]
at javafx.scene.control.TreeTableView$TreeTableViewArrayListSelectionModel.clearAndSelect(TreeTableView.java:2823) ~[javafx-controls-14-linux.jar:?]
at com.sun.javafx.scene.control.behavior.TableCellBehaviorBase.simpleSelect(TableCellBehaviorBase.java:213) ~[javafx-controls-14-linux.jar:?]
at com.sun.javafx.scene.control.behavior.TableCellBehaviorBase.doSelect(TableCellBehaviorBase.java:195) ~[javafx-controls-14-linux.jar:?]
at com.sun.javafx.scene.control.behavior.CellBehaviorBase.mousePressed(CellBehaviorBase.java:176) ~[javafx-controls-14-linux.jar:?]
at com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274) ~[javafx-controls-14-linux.jar:?]
at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74) ~[javafx-base-14-linux.jar:?]
at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54) ~[javafx-base-14-linux.jar:?]
at javafx.event.Event.fireEvent(Event.java:198) ~[javafx-base-14-linux.jar:?]
at javafx.scene.Scene$MouseHandler.process(Scene.java:3890) ~[javafx-graphics-14-linux.jar:?]
at javafx.scene.Scene.processMouseEvent(Scene.java:1885) ~[javafx-graphics-14-linux.jar:?]
at javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2618) ~[javafx-graphics-14-linux.jar:?]
at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:409) ~[javafx-graphics-14-linux.jar:?]
at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:299) ~[javafx-graphics-14-linux.jar:?]
at java.security.AccessController.doPrivileged(AccessController.java:391) ~[?:?]
at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(GlassViewEventHandler.java:447) ~[javafx-graphics-14-linux.jar:?]
at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:412) ~[javafx-graphics-14-linux.jar:?]
at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:446) ~[javafx-graphics-14-linux.jar:?]
at com.sun.glass.ui.View.handleMouseEvent(View.java:556) ~[javafx-graphics-14-linux.jar:?]
at com.sun.glass.ui.View.notifyMouse(View.java:942) ~[javafx-graphics-14-linux.jar:?]
at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method) ~[javafx-graphics-14-linux.jar:?]
at com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277) ~[javafx-graphics-14-linux.jar:?]
at java.lang.Thread.run(Thread.java:832) [?:?]

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 25, 2020
@Siedlerchr
Copy link
Member

I'm still hesitating to merge this, because I want to know why this error happens or moreover why it's happening, although we have "opened" up the module for modifications in the gradle file. hm

@koppor
Copy link
Member

koppor commented Jun 16, 2020

I believe that "more stable" is true and is a good thing for JabRef.

I also think its a good thing to find out why the exception occurs. Thus, I created #6616 and will merge this PR.

@koppor koppor merged commit 2ad23e3 into JabRef:master Jun 16, 2020
Siedlerchr added a commit that referenced this pull request Jun 20, 2020
* upstream/master:
  Validates the file path of a TexGroup and fixes Texgroup's "Library has been modified by another program" (#6586)
  Bump postgresql from 42.2.12 to 42.2.14 (#6610)
  Add markdown-link-check (#6542)
  Catch InaccessibleObjectException (#6519)
  Fix author formatter for unchanged names (#6552)
  Bump com.simonharrer.modernizer from 1.8.0-1 to 2.1.0-1
  Bump org.beryx.jlink from 2.19.0 to 2.20.0
  Bump classgraph from 4.8.83 to 4.8.86
  Update FileUtilTest.java
  Update FileUtilTest.java
  Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635
  Update FileUtilTest.java
  Update MoveFilesCleanupTest.java
  checkstyle
  Fix dowmloaded files moved to citaiton key dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants