Fix author formatter for unchanged names #6552

k3KAW8Pnf7mkmdSMPHz27 · 2020-05-29T17:30:03Z

Fixes an issue created in #6479 where the "Format of author and editor names", Show names unchanged option does not resolve umlauts/latex.

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

The original condition is evaluated to false. The substring is shorter than "uni".

Perhaps the assumption should be that the letters are ASCII. If all letters are ASCII checking 'A' <= k.charAt(0) <= 'Z' might make more sense. I am not convinced about doing this with a regex.

Both test cases involves an author name containing department or school without university or institute of technology.

Corporate authors without university/institute of technology

# Conflicts: # src/main/java/org/jabref/logic/bibtexkeypattern/BracketedPattern.java

If the name of an institution can't be split, assume that "School"/"Department" is part of the name.

Minor typos and the "rest" part is now created differently.

Move the fields loop from BibEntryTableViewModel to MainTableFieldValueFormatter.

src/main/java/org/jabref/model/entry/AuthorList.java

Store a reference to the used BibDatabase in MainTableFieldValueFormatter with the constructor.

tobiasdiez

Thanks for the update. Looks already pretty good to me, and I've only few more minor comments.

src/main/java/org/jabref/gui/maintable/MainTableDataModel.java

src/main/java/org/jabref/gui/maintable/MainTableFieldValueFormatter.java

src/main/java/org/jabref/model/entry/AuthorList.java

Co-authored-by: Tobias Diez <tobiasdiez@gmx.de>

…dSMPHz27/jabref into fix-for-issue-6459

koppor

Thank you for the hard work. I have some code nitpicks.

And a hint to get checkstyle running again:

Please add MainTableFieldValueFormatter.java to

jabref/config/checkstyle/checkstyle.xml

Line 15 in ca06b71

    
           <property name="fileNamePattern" value="AuthorAndsReplacer.java|Ordinal.java|EntryTypeView.java" />

Refs checkstyle/checkstyle#6615

src/main/java/org/jabref/model/entry/AuthorList.java

This reverts commit 6155e14

…dSMPHz27/jabref into fix-for-issue-6459

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

…dSMPHz27/jabref into fix-for-issue-6459

* upstream/master: Validates the file path of a TexGroup and fixes Texgroup's "Library has been modified by another program" (#6586) Bump postgresql from 42.2.12 to 42.2.14 (#6610) Add markdown-link-check (#6542) Catch InaccessibleObjectException (#6519) Fix author formatter for unchanged names (#6552) Bump com.simonharrer.modernizer from 1.8.0-1 to 2.1.0-1 Bump org.beryx.jlink from 2.19.0 to 2.20.0 Bump classgraph from 4.8.83 to 4.8.86 Update FileUtilTest.java Update FileUtilTest.java Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635 Update FileUtilTest.java Update MoveFilesCleanupTest.java checkstyle Fix dowmloaded files moved to citaiton key dir

6b7fdff8cb Create journal-of-the-american-philosophical-association.csl (#6542) 9bae9efc55 Update german-council-of-economic-experts.csl (#6562) 256250be9c Update springer-vancouver-brackets.csl (#6546) f422ca9c9a Update turabian-fullnote-bibliography.csl (#6540) 2833b5d5d5 Update mots.csl (#6556) 44758704b0 Update and rename harvard-the-university-of-melbourne.csl to dependen… (#6547) 08e65fc8e1 Update ieee-with-url.csl (#6514) 06e98f4387 Fix erroneous comma in ACL in-text citation (#6553) 72e16a19cd Update bibliothek-forschung-und-praxis.csl (#6527) 50bae82394 Create Food and Agriculture Organization of the United Nations (numeric) (#6544) 234a3c35d8 Update bern-university-of-applied-sciences-school-of-agricultural-for… (#6552) 3e9e2d6e93 Fix et al and name settings in universitat bern institut fur sozialanthropologie (#6554) e8e06888fe Update harvard-university-of-the-west-of-england.csl (#6520) dbbe5c1a95 Update united-states-international-trade-commission.csl (#6535) b985431f03 Update american-society-for-horticultural-science.csl (#6543) e1ff9f5546 Sort APA and derivatives on displayed date, not full date (#6545) 7302832d6d Localize original-work-published in APA (#6388) 77a61c0d82 Update united-states-international-trade-commission.csl (#6526) 541807a057 Update the-accounting-review.csl (#6521) 708626357a Update united-states-international-trade-commission git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 6b7fdff8cb0fb45b342e8ac319634bf18168c73d

k3KAW8Pnf7mkmdSMPHz27 added 30 commits May 13, 2020 11:06

Fix Pattern.compile for frequently used regexes

fd405cf

Fix one additional Pattern.compile

a6354e3

Fix style and unnecessary escape sequences

149ed4f

Fix invalid index in call to substring

b57f1b2

The original condition is evaluated to false. The substring is shorter than "uni".

Refactor name and javadoc of a regex

fae093b

Fix use of compiled regex for matching department

5a23a9a

Fix check for uppercase letter

6af8c7e

Perhaps the assumption should be that the letters are ASCII. If all letters are ASCII checking 'A' <= k.charAt(0) <= 'Z' might make more sense. I am not convinced about doing this with a regex.

Fix usage of uncompiled regex

716f885

Fix readability?

cdfd56a

Add test cases

b227edb

Both test cases involves an author name containing department or school without university or institute of technology.

Fix null appearing as part of author name

ef7f979

Corporate authors without university/institute of technology

Refactor name of capital regex pattern

9ac3993

Merge branch 'master' into fix-for-issue-6459

85c96ce

# Conflicts: # src/main/java/org/jabref/logic/bibtexkeypattern/BracketedPattern.java

Add debug output for reordering of names in fields

6ded410

Merge branch 'master' into fix-for-issue-6459

e8c3007

Add helper methods

72eb1fe

Fix missing negation in "uni" matching

2eee8dd

Fix test cases for corporate authors

cc54029

Fix to keep all uppercase letters in abbreviation

1063ae1

Fix commented out code

ef94758

Fix key for institution's name containing keyword

e80bd8b

If the name of an institution can't be split, assume that "School"/"Department" is part of the name.

Fix test case for short institution name

a0ed455

Refactor check for institution types

4db0824

Refactor comments and names improving readability?

383fc14

Refactor to improve readability and closure

c3e5f09

Fix JavaDoc

5990c2a

Minor typos and the "rest" part is now created differently.

Fix JavaDoc typos

0df3cdb

Fix preliminary order for authors -> latexfree

f0d9601

Drop logger

6f26a73

Add convenience methods for cached latexfree names

9b717c5

Refactor the fields loop

0942e2c

Move the fields loop from BibEntryTableViewModel to MainTableFieldValueFormatter.

k3KAW8Pnf7mkmdSMPHz27 commented Jun 9, 2020

View reviewed changes

src/main/java/org/jabref/model/entry/AuthorList.java Outdated Show resolved Hide resolved

k3KAW8Pnf7mkmdSMPHz27 added 2 commits June 9, 2020 17:48

Fix typo in formatFieldValueLatexFree

3e562d8

Fix reference of bibDatabaseContext in Formatter

7616fbe

Store a reference to the used BibDatabase in MainTableFieldValueFormatter with the constructor.

k3KAW8Pnf7mkmdSMPHz27 marked this pull request as ready for review June 10, 2020 16:39

Fix access modifier

4c457f3

k3KAW8Pnf7mkmdSMPHz27 requested a review from tobiasdiez June 12, 2020 16:05

tobiasdiez requested changes Jun 16, 2020

View reviewed changes

k3KAW8Pnf7mkmdSMPHz27 and others added 6 commits June 16, 2020 09:25

Fix that removes "LatexFree" when it is implied

d183705

Fix that restores class variable entriesFiltered

431811a

Fix handling of DisplayStyle.AS_IS

8ad3aaf

Co-authored-by: Tobias Diez <tobiasdiez@gmx.de>

Drop AuthorList caching of unformatted string

a81f1e9

Merge branch 'fix-for-issue-6459' of https://github.com/k3KAW8Pnf7mkm…

c55b1b6

…dSMPHz27/jabref into fix-for-issue-6459

Merge branch 'master' into fix-for-issue-6459

c8380a8

koppor requested changes Jun 16, 2020

View reviewed changes

src/main/java/org/jabref/model/entry/AuthorList.java Outdated Show resolved Hide resolved

k3KAW8Pnf7mkmdSMPHz27 and others added 2 commits June 16, 2020 14:47

Add MainTableFieldValueFormatter to checkstyle

6155e14

Add MainTableFieldValueFormatter to exclusion list

1eeddab

koppor changed the title ~~Fix author forrmatter for names unchanged~~ Fix author formatter for unchanged names Jun 16, 2020

k3KAW8Pnf7mkmdSMPHz27 and others added 6 commits June 16, 2020 15:08

Fix JavaDoc for Author.equals

2ff9553

Revert "Add MainTableFieldValueFormatter to ..."

2396fb2

This reverts commit 6155e14

Merge branch 'fix-for-issue-6459' of https://github.com/k3KAW8Pnf7mkm…

b16d457

…dSMPHz27/jabref into fix-for-issue-6459

Fix JavaDoc description of AuthorList.equals

a9e4f72

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

Merge branch 'fix-for-issue-6459' of https://github.com/k3KAW8Pnf7mkm…

d7d692e

…dSMPHz27/jabref into fix-for-issue-6459

Fix JavaDoc adherence with Author.equals

0c0e777

koppor merged commit fcf6146 into JabRef:master Jun 16, 2020

Siedlerchr mentioned this pull request Jun 22, 2020

jabref does not shut down (on Linux); process keeps running #6559

Closed

1 task

k3KAW8Pnf7mkmdSMPHz27 mentioned this pull request Dec 22, 2020

Fixes miss-parsed names in AutomaticPersonsGroup #7228

Merged

5 tasks

k3KAW8Pnf7mkmdSMPHz27 mentioned this pull request Jan 6, 2021

Suggestions for changes in caching latex free authors #7301

Merged

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix author formatter for unchanged names #6552

Fix author formatter for unchanged names #6552

k3KAW8Pnf7mkmdSMPHz27 commented May 29, 2020 •

edited

Loading

tobiasdiez left a comment

koppor left a comment

Fix author formatter for unchanged names #6552

Fix author formatter for unchanged names #6552

Conversation

k3KAW8Pnf7mkmdSMPHz27 commented May 29, 2020 • edited Loading

tobiasdiez left a comment

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

k3KAW8Pnf7mkmdSMPHz27 commented May 29, 2020 •

edited

Loading