Fix Preferences style value too long

[leitianjian]

Fixes #6198

Here are some explanations

origin of the bug
The listener add on chosenSelectionModelProperty

jabref/src/main/java/org/jabref/gui/preferences/PreviewTabView.java

Line 146 in 14e9790

chosenListView.selectionModelProperty().getValue().selectedItemProperty().addListener((observable, oldValue, newValue) -> viewModel.setPreviewLayout(newValue));

When we want to remove some cell from the chosenListProperty, before the remove operation is done. The selectionModel modified listener was fired (remove modified selectionModel too). Then the sourceTextProperty in PreviewTabViewModel.java was modified, which will fire the listener add on sourceTextProperty

jabref/src/main/java/org/jabref/gui/preferences/PreviewTabViewModel.java

Lines 79 to 83 in 14e9790

	sourceTextProperty.addListener((observable, oldValue, newValue) -> {
	if (getCurrentLayout() instanceof TextBasedPreviewLayout) {
	((TextBasedPreviewLayout) getCurrentLayout()).setText(sourceTextProperty.getValue().replace("\n", "__NEWLINE__"));
	}
	});

The lambda above will modify the choseListProperty first elements.

So, my solution is clear the selection before we remove some elements
The drag cases are a little bit difficult.
I add a field named dragSourceSelectionModel which is similar to dragSourceList
After these modifications, I think the bug was solved.

I don't know why the merged changes appear again, maybe someone has rollbacked the master branch? I checked the code in the master, which seems the fixes of the issues #6169 have been dropped?

Thanks for any instruction in advanced.

• Change in CHANGELOG.md described (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

[Siedlerchr]

I don't know why the merged changes appear again, maybe someone has rollbacked the master branch? I checked the code in the master, which seems the fixes of the issues #6169 have been dropped?

Try to merge in the changes from upstream/master

[calixtus]

Codewise looks good to me, thank you very much.

[calixtus]

I think the changelog entry is wrong. Please change that.
Or at least not complete. Just add another entry for the fix about issue #6198

[leitianjian]

I don't know why the merged changes appear again, maybe someone has rollbacked the master branch? I checked the code in the master, which seems the fixes of the issues #6169 have been dropped?

Try to merge in the changes from upstream/master

I don't know why git fetch upstream does not fetch the upstream changes. After pull the changes from upstream. I think the problem was solved. Thank for your tips。

I think the changelog entry is wrong. Please change that.
Or at least not complete. Just add another entry for the fix about issue #6198

I modified the changelog entry. Please check it again. Thanks

[calixtus]

Looks. Good. Thank you for your contribution.
I hope you liked working with JabRef. As you can see, there is still plenty to be done, many bugs to fix and enough space to add ideas of your own to this software. We would be happy if you consider to contribute more.

[Siedlerchr]

Thanks again for contributing! The changes look good to me as well