Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4591] Add Integrity check for books with edition reported as 1 #4642

Merged
merged 3 commits into from
Feb 13, 2019
Merged

[#4591] Add Integrity check for books with edition reported as 1 #4642

merged 3 commits into from
Feb 13, 2019

Conversation

RonakLakhotia
Copy link
Contributor

Fixes #4591

@RonakLakhotia
Copy link
Contributor Author

@tobiasdiez @Siedlerchr could you review this pr, also I am not sure why travis is failing

@Siedlerchr
Copy link
Member

@RonakLakhotia If you click on the travis build failed (Details) you can expand the failing job, in your case it's just the localization test which failed. You need to add the string to the english localization file under src/main/resources/l10n

org.jabref.logic.l10n.LocalizationConsistencyTest > findMissingLocalizationKeys() FAILED
    org.opentest4j.AssertionFailedError: DETECTED LANGUAGE KEYS WHICH ARE NOT IN THE ENGLISH LANGUAGE FILE
    PASTE THESE INTO THE ENGLISH LANGUAGE FILE
    edition\ of\ book\ reported\ as\ just\ 1=edition of book reported as just 1
     ==> expected: <[]> but was: <[edition\ of\ book\ reported\ as\ just\ 1 (src/main/java/org/jabref/logic/integrity/EditionChecker.java LANG)]>
        at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
        at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:195)
        at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:184)
        at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1135)
        at org.jabref.logic.l10n.LocalizationConsistencyTest.findMissingLocalizationKeys(LocalizationConsistencyTest.java:111)

@RonakLakhotia
Copy link
Contributor Author

RonakLakhotia commented Feb 8, 2019 •
edited
Loading

Thanks for the pointer! Fixed the failing test. Ready for review

@RonakLakhotia
Copy link
Contributor Author

RonakLakhotia commented Feb 9, 2019 •
edited
Loading

@tobiasdiez @Siedlerchr ready for review

tobiasdiez
tobiasdiez approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me (I've one very small suggestion for improvement, but it's fine to merge also in the current state).

src/main/java/org/jabref/logic/integrity/EditionChecker.java Outdated
return Optional.of(Localization.lang("should have the first letter capitalized"));
}

if (value.equals(FIRST_EDITION)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would move this check before the biblatex/bibtex checks (then you don't need to modify the conditions of these if statements).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasdiez yes, it makes more sense. Updated PR.

@matthiasgeiger matthiasgeiger added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 10, 2019
@RonakLakhotia RonakLakhotia reopened this Feb 10, 2019
@Siedlerchr
Copy link
Member

You can ignore the outdated dependencies. It's one of the tasks which is allowed to fail.

@RonakLakhotia
Copy link
Contributor Author

Build passed, Ready for review !

@RonakLakhotia
Copy link
Contributor Author

Any updates?

@tobiasdiez
Copy link
Member

@RonakLakhotia We have the policy that at least two core developers have to approve a pull request before me merge. Since we are all working on JabRef in our freetime, reviewing of a PR might take a day or two (especially over the weekend).

But that shouldn't stop you from looking and working at other open issues if you have the motivation and the drive to do so!

@koppor koppor merged commit 4844541 into JabRef:master Feb 13, 2019
@fspreng fspreng mentioned this pull request Sep 2, 2019
Closed
github-actions bot pushed a commit that referenced this pull request Mar 29, 2020
Squashed 'src/main/resources/csl-styles/' changes from fa6bb22..ddf2572
2566fe0 
ddf2572 Create universitat-stuttgart-mpp-standard.csl (#4639)
bde92d6 Update environmental-microbiology.csl (#4641)
efa68bc Update presses-universitaires-de-rennes.csl (#4640)
0872e3e Fixes #4648 (#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (#4634)
e5f9eed Update ieee.csl (#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (#4637)
7365ce8 fix editor label for french apa.csl (#4616)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: ddf2572
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
f26b6ce 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 7365ce8..a51eb4f
75a55aa 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from db8bd33..a51eb4f
9bdcdc8 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
736d704 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to abepolk/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
3c303db 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
7d52068 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 0cb6762..a51eb4f
9be2604 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request Apr 16, 2020
Squashed 'src/main/resources/csl-styles/' changes from fa6bb22..06785fa
d5c3408 
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 06785fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check for books with first edition
5 participants
@RonakLakhotia @Siedlerchr @tobiasdiez @matthiasgeiger @koppor