Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework external changes dialog in JavaFX #4693

Merged
merged 5 commits into from
Mar 12, 2019
Merged

Rework external changes dialog in JavaFX #4693

merged 5 commits into from
Mar 12, 2019

Conversation

tobiasdiez
Copy link
Member

Convert "External changes" dialog to JavaFX.

Notification is now at the top of the library instead of in the sidepane:
image

Converted dialog:
image


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 22, 2019
@Siedlerchr
Copy link
Member

Siedlerchr commented Feb 23, 2019

I can't get it work properly.
Open a JabRf bib file.
Modify the bib file externally in Notepad++
Save the change sin Notepad++
JabRef does not show anything.

I debugged and set a breakpoint;
And I could capture an
Not on FX application thread; currentThread = pool-3-thread-5

 public EntryChangeViewModel(BibEntry memEntry, BibEntry tmpEntry, BibEntry diskEntry) {

         fieldChanges.add(new FieldChangeViewModel(field, memEntry, tmpEntry, mem.orElse(null), tmp.orElse(null),   disk.orElse(null))); //this line causes the exception

The problematic class is this: The WebView must be initialized on FX Thread

 static class FieldChangeViewModel extends DatabaseChangeViewModel {

        private final BibEntry entry;
        private final BibEntry tmpEntry;
        private final String field;
        private final String inMem;
        private final String onDisk;
        private final WebView tp = new WebView();

@Siedlerchr
Copy link
Member

And the GUI is unreadable has hell:
grafik

And there is also a problem when doing multiple changes before I click on any review:
grafik

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see screenshots

@tobiasdiez
Copy link
Member Author

God damn, was I too lazy to provide a properly working interface. Now everything should be fine (will still not win a prize for best ui).

@tobiasdiez tobiasdiez merged commit 930fa4e into master Mar 12, 2019
@tobiasdiez tobiasdiez deleted the changesJavaFX branch March 12, 2019 20:47
Siedlerchr added a commit that referenced this pull request Mar 16, 2019
…erbibtexkey

* upstream/master: (827 commits)
  [#4306] Disable renaming (#4727)
  Feature: implement search filter in show preferences (#4759)
  Enable import button only if entry selected (#4761)
  Improve Remote messaging (#4760)
  Add changelog entry for #4520
  Modifications to improve contrast of UI elements (#4758)
  Rework external changes dialog in JavaFX (#4693)
  Changes the title of Group Dialog to Add subgroup when adding a new subgroup (#4757)
  Optimize data fetching (#4520)
  Adds a browse button next to the path text field for aux-based groups (#4743)
  Saving changes and exiting application (#4729)
  Code optimized and created a reusable method to get writer output (#4750)
  Bump mvvmfx from 1.7.0 to 1.8.0 (#4747)
  Bump guava from 27.0.1-jre to 27.1-jre (#4748)
  Bump mvvmfx-validation from 1.7.0 to 1.8.0 (#4749)
  Remove obsolete swing components in Preferences and OpenOffice (#4740)
  Move library specific key pattern dialog call to library menu (#4744)
  Revert "Revert "Fix: bibkey generated does not handle diacritics" (#4741)" (#4742)
  Revert "Fix: bibkey generated does not handle diacritics" (#4741)
  Rename method to removeUnwantedCharacters
  ...
github-actions bot pushed a commit that referenced this pull request Apr 14, 2020
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (#4701)
bbdc9c4 Update to better match RMIT Easy Cite (#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (#4705)
449eaec add DOI to mdpi.csl back (#4695)
642002e Create muni-law.csl (#4691)
483d04a Create iso690-author-date-pt (#4694)
505c006 Update pravnik.csl (#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (#4686)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c31d9ca
github-actions bot pushed a commit to magsilva/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to abepolk/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Apr 15, 2020
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c1793d2
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request Apr 16, 2020
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)
c1793d2 Create isnad-metinici.csl (JabRef#4704)
099f4a1 Create isnad-dipnotlu.csl (JabRef#4703)
8e8639e Update norois.csl (JabRef#4706)
62f6221 Create amsterdam-university-press.csl (JabRef#4699)
c31d9ca Create tagungsberichte-der-historischen-kommission-fur-ost-und-westpr… (JabRef#4700)
34220d3 Change apa-fr-provost.csl to fr-CA locale (JabRef#4701)
bbdc9c4 Update to better match RMIT Easy Cite (JabRef#4697)
7c506d9 Create Anatomia Histologia Embryologia csl file (JabRef#4688)
61f3dc5 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl and iso690-full-note-cs.csl (JabRef#4705)
449eaec add DOI to mdpi.csl back (JabRef#4695)
642002e Create muni-law.csl (JabRef#4691)
483d04a Create iso690-author-date-pt (JabRef#4694)
505c006 Update pravnik.csl (JabRef#4690)
eb260ef Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4692)
9279f0d Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4693)
70f7be6 Create iso690-full-note-cs-pravnik.csl (JabRef#4686)
db54e56 Update CONTRIBUTING.md
2f16a9b Update CONTRIBUTING.md
4cd05ba Create associacao-brasileira-de-normas-tecnicas-ufrgs-footnote-ibid.csl (JabRef#4369)
4d4655e Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4684)
5948265 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4683)
f8b744c Create aberdeen-university-school-of-education-harvard.csl (JabRef#4685)
807930a Update trabajos-de-prehistoria.csl (JabRef#4680)
c25709f Update society-for-american-archaeology.csl (JabRef#4681)
86f888a Update archeosciences.csl (JabRef#4682)
99c4fd3 Create sylwan.csl (JabRef#4678)
d9ba2de Update equine-veterinary-education.csl (JabRef#4677)
7d30659 Update equine-veterinary-education.csl (JabRef#4675)
9a7791f Update equine-veterinary-education.csl (JabRef#4674)
0a46235 Create norois.csl (JabRef#4673)
88726cb Update Rhinology (JabRef#4672)
900e4d5 Create revista-de-biologia-marina-y-oceanografia.csl (JabRef#4671)
01672e3 polimdosains-politeknik-negeri-manado.csl (JabRef#4662)
d97d4b7 Update iso690-author-date-sk.csl (JabRef#4669)
22e0bab Create trabajos-de-prehistoria.csl (JabRef#4670)
6c6bf37 Create proceedings-of-the-joint-international-grassland-and-international-rangeland-congress-2021.csl (JabRef#4667)
b91deaf Create rhinology.csl (JabRef#4666)
d3b58b2 Add OSA dependents (JabRef#4668)
a0d4bab Create the-international-journal-of-tuberculosis-and-lung-disease.csl (JabRef#4663)
5a865de Update harvard-university-for-the-creative-arts.csl (JabRef#4665)
8695d97 Update societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4660)
0dc2e37 Update freshwater-science.csl (JabRef#4658)
118cfab Update ayer.csl (JabRef#4659)
3ba11bc Create optics-letters.csl (JabRef#4661)
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 06785fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants