Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 10423 #10517

Closed
wants to merge 9 commits into from
Closed

Conversation

u7492883
Copy link
Contributor

Added a fetcher for the webside ISIDORE, (https://isidore.science/). The fetcher will get all the fields that it can find and will convert them into a BibEntry.
Fixes #10423.

screenshotISIDORE

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Tal Shy-Tielen and others added 9 commits October 17, 2023 19:30
Created a fetcher that would automatically fill referencing information from ISIDORE. Unfortunately the XML files are not always formatted the same way which increased the number of methods in this fetcher compared to the others.
Added the ISIDOREFetcher to the list of WebFetchers, on line 149.
Added tests for the ISIDORE fetcher.
Fixed case where doi would not be added correctly.
Added ISIDORE's privacy policy link to PRIVACY.md.
@u7492883 u7492883 closed this Oct 18, 2023
@Siedlerchr
Copy link
Member

It looked already good on a first quick look, no idea why you closed this. I would maybe sugget to use the json output insteaed of the xml and addtionally I would implement it as SearchBasedParserFetcher

@u7492883
Copy link
Contributor Author

Sorry I named it incorrectly so I opened a new pull request that was more descriptive. I did not use the json output as I believe there is a bug where it does not work, as an example the following link https://api.isidore.science/resource/content?output=json&uri=10670/1.d2vlam, should output a json file but it only gives the xml file. Please let me know if I have made a mistake here.

@koppor
Copy link
Member

koppor commented Oct 24, 2023

For reference, the new PR is #10518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new Fetcher for Isidore.science
3 participants