Scrollingthroughentrylisttest #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Braunch
changed the title
Braunch
force-pushed
the
scrollingthroughentrylisttest#988
branch
from
226ccc6
to
77bcd18
Compare
|
|
||
| //reduce the delay to speed up loading the test resource | ||
| robot().settings().delayBetweenEvents(10); | ||
| openFileChooser.fileNameTextBox().enterText(getTestFilePath(TEST_FILE_NAME)); |
There was a problem hiding this comment.
If I see right, you just want the file path as a string. So I don't think you need getTestFilePath method if you're using java.nio.path.
See here for an example.
Current coverage is 28.41%@@ master #1361 diff @@
==========================================
Files 695 695
Lines 46266 46266
Methods 0 0
Messages 0 0
Branches 7646 7646
==========================================
Hits 13144 13144
Misses 31992 31992
Partials 1130 1130
|
Braunch
force-pushed
the
scrollingthroughentrylisttest#988
branch
from
c52d448
to
ec50739
Compare
|
I created an |
chriba
force-pushed
the
scrollingthroughentrylisttest#988
branch
4 times, most recently
from
69c3ce1
to
d0ff0ba
Compare
|
should work now on windows 👍 |
Braunch
force-pushed
the
scrollingthroughentrylisttest#988
branch
from
d0ff0ba
to
f08f9d8
Compare
chriba
force-pushed
the
scrollingthroughentrylisttest#988
branch
2 times, most recently
from
a5b07da
to
b72501e
Compare
tschechlovdev
added
status: ready-for-review
tschechlovdev
changed the title
chriba
force-pushed
the
scrollingthroughentrylisttest#988
branch
from
b72501e
to
d1ee816
Compare
|
Is there any feedback on this Pull-Request? |
| * The backlashes are replaced with forwardslashes b/c assertJ can't type the former one on windows | ||
| */ | ||
| protected String getAbsolutePath(String relativePath) { | ||
| return new File(this.getClass().getClassLoader().getResource(relativePath).getFile()).getAbsolutePath().replace("\\", "/"); |
There was a problem hiding this comment.
Please try to use Path instead of File
| import static org.assertj.swing.finder.WindowFinder.findFrame; | ||
| import static org.assertj.swing.launcher.ApplicationLauncher.application; | ||
|
|
||
| public abstract class AbstractUITest extends AssertJSwingJUnitTestCase { |
chriba
force-pushed
the
scrollingthroughentrylisttest#988
branch
from
bb77b52
to
5b75ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a ui-test for the following use case:
I import a bib-file into a new database.
Then I double-click on the first entry in the database to open up the entry editor.
Then I click back into the table and start scrolling through the entries.
When I do that, the table should always keep the focus.
This test case tests the following pull-requests enhancement: #988
It also referes to the discussion about ui-testing: #507