When clicking on a tab, the first field now has the focus #988

Braunch · 2016-03-17T22:09:23Z

Change in CHANGELOG.md described?
Changes in pull request outlined? (What, why, ...)
Tests created for changes?
Tests green?

This is referes to #623
I just had to add the activateVisible() Method to the ChangeListener to ensure the focus is set.

simonharrer · 2016-03-17T22:35:40Z

What happens if I am scrolling through the list of entries in the table via the keys? Does the focus can jump away to the field editor if it is open? From what I recall, we had the issue I mentioned before and had to remove the functionality to automatically focus the first field. Please test this exhaustively with different entry editors for different entry types open and then scrolling via keys.

Braunch · 2016-03-20T18:54:21Z

I am going to figure that out after our exam this week. So your comment is recognized :)

Braunch · 2016-04-18T13:58:33Z

I had a chat with @koppor today. @bruehldev and I will write an automated test for this in our upcoming sprint (starting on monday 25th april). When this is done we should have verified if the focus is lost on scrolling or not.

stefan-kolb · 2016-07-12T13:57:34Z

What is the current status here?

Braunch · 2016-07-12T16:18:19Z

I have run the Integration tests on it and tried it manually. The entry tables focus is not lost when going through the entries. Only when opening the entry editor as intended.

simonharrer · 2016-07-12T19:23:06Z

I wonder why the travis jobs are not executed? Because you violate the correct imports order, and this cannot be merged without the build failing at the moment.

Braunch · 2016-07-13T12:38:49Z

I will fix the order soon. Probably on Friday. Maybe pushing on the branch will then trigger the jobs again.

tobiasdiez · 2016-07-13T18:40:17Z

CHANGELOG.md

@@ -19,6 +19,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - When resolving duplicate BibTeX-keys there is now an "Ignore" button. "Cancel" and close key now quits the resolving.
 - The [online forum](http://discourse.jabref.org/) is now directly accessible via the "Help" menu
 - Implemented [#1338](https://github.com/JabRef/jabref/issues/1338): clicking on a crossref in the main table selects the parent entry and added a button in the entry editor to select the parent entry.
+- [#623](https://github.com/JabRef/jabref/issues/623) The first Field does now have focus when clicking on a tab in the entry editor


The first field now has focus ...

tobiasdiez · 2016-07-13T18:42:21Z

LGTM 👍, just fix the import order (and improve the changelog), then this can be merged in from my point of view

Braunch · 2016-07-19T12:20:20Z

Can this be merged?

simonharrer · 2016-07-19T19:01:12Z

why did the gradlew scripts change?

simonharrer · 2016-07-19T19:02:07Z

otherwise LGTM

…y editor

Braunch · 2016-07-21T11:48:39Z

Gradle scripts are back to normal.

stefan-kolb · 2016-07-21T11:54:53Z

OK 👍

* master: (268 commits) Added DateFormatter to LayoutEntry so that it actually works... (JabRef#1619) Implemented JabRef#1345 - cleanup ISSN (JabRef#1590) Always use https for help files (JabRef#1615) Resolves JabRef#1613 Use Jabref default icon for uninstaller for now (JabRef#1616) Added more fields and fixed some issues (JabRef#1617) Added LayoutFormatterPreferences (and related files) (JabRef#1608) [WIP] Create new fetcher infrastructure (JabRef#1594) Set user agent to fix 403 status error More fields added to FieldName (JabRef#1614) Added model.entry.FieldName that contains field name constants (JabRef#1602) Fixes imports Test CustomImporter (JabRef#1501) The field list gets the focus as soon as it is focused (JabRef#1541) When clicking on a tab, the first field now has the focus (JabRef#988) Add test in BibEntryWriterTest for type change Rewrite MedlineImporter with JAXB and add nbib fields (JabRef#1479) Some Globals.prefs injection in logic and model (JabRef#1593) Added filter to not show selected integrity checks (JabRef#1588) Replace getField with getFieldOptional in all of the tests and in som… (JabRef#1591) Move preferences (JabRef#1604) ... # Conflicts: # src/main/java/net/sf/jabref/importer/ImportMenuItem.java # src/main/java/net/sf/jabref/importer/OpenDatabaseAction.java

@comment

Move event (JabRef#1601) * Move event package to model Update dependencies: postgres 9.4.1208 -> 9.4.1209 and wiremock from 2.1.6 to 2.1.7 Added ISBN integrity checker (JabRef#1586) Added ISBN integrity checker * Extracted ISBN class Reenable errorprone (see http://errorprone.info/) Extend the OpenConsoleFeature (JabRef#1582) * Extend the OpenConsoleFeature by selection of custom terminal emulator. - Add radio selection to the AdvancedTab - Add new JabRefPreferences - Add file check and execution commands - Add localization keys * Fix localization key. * Move console selection to ExternalTab.java * Change localization entry. * Add command executor. * Fix placeholder replacement. * Fix codacy. * Update localization key. * Remove "Specify terminal emulator" option. Add GUI outputs. * Set default command for Windows. Fix localization entries. * Remove empty lines in language files. * Use lambda expressions insead of ActionListeners * Refactoring. * Update CHANGELOG.md. * Small refactorings. Move preferences (JabRef#1604) * Move preferences-related classes into separate package * Rename JabRefPreferencesFilterDialog -> PreferencesFilterDialog and move it to gui * Fix checkstyle warning Set user agent to fix 403 status error Replace getField with getFieldOptional in all of the tests and in som… (JabRef#1591) * Replace getField with getFieldOptional in all of the tests and in some more code * Some more conversions Added filter to not show selected integrity checks (JabRef#1588) * Added filter to not show selected integrity checks * Removed unused variable Some Globals.prefs injection in logic and model (JabRef#1593) * Some Globals.prefs injection in logic and model * Some more conversions and some fixes * More injections * Even more injections * Yes, even more injections * Indeed, even more injections * Probably the last injections for now * Removed unrequired dependency and fixed issue * Dropped support for selecting sub/super to equations * Added preference classes for LatexFieldFormatter and FieldContentParser * Removed some left over code * Added JournalAbbreviationPreferences * Encapsulated LatexFieldFormatterPreferences in SavePreferences * Changed getShortDescription to accept boolean argument * Removed Globals.prefs from tests and removed unused imports * Unused import * Unused import Rewrite MedlineImporter with JAXB and add nbib fields (JabRef#1479) Add test in BibEntryWriterTest for type change When clicking on a tab, the first field now has the focus (JabRef#988) * the first Field does now have focus when clicking on a tab in the entry editor * Make first field focused when selecting a tab in entry editor The field list gets the focus as soon as it is focused (JabRef#1541) Test CustomImporter (JabRef#1501) * Test CustomImporter Fixes imports Added model.entry.FieldName that contains field name constants (JabRef#1602) * Added model.entry.FieldName that contains field name constants * More constants * Renamed and added more constants * Some more fields and cleanups * Removed MedlineHandler left from merge conflicts More fields added to FieldName (JabRef#1614) * More fields added to FieldName * Some Medline fixes [WIP] Create new fetcher infrastructure (JabRef#1594) * Introduce new Fetcher interfaces * Refactor arXiv fulltext fetcher * Add query based arXiv fetcher * Reformat code * Add a few tests for the arxiv parser * Make new arXiv fetcher available * Fix small problems related to files * Fix tests * Rename interface methods * Add changelog entry * Mark old EntryFetcher interface as deprecated * Move fetcher to importer \ fetcher * Move HelpFile from gui.help to logic.help * Rename fetchers * Rename FulltextFinder * Optimize imports * Fix failing test * Ignore failing test Added LayoutFormatterPreferences (and related files) (JabRef#1608) * Added LayoutFormatterPreferences (and related files) * Rebased * Included JournalAbbreviationLoader in LayoutPreferences Added more fields and fixed some issues (JabRef#1617) Resolves JabRef#1613 Use Jabref default icon for uninstaller for now (JabRef#1616) Always use https for help files (JabRef#1615) Implemented JabRef#1345 - cleanup ISSN (JabRef#1590) * Implemented JabRef#1345 - cleanup ISSN * Fixed comments * Extracted ISSN class * Added tests for ISSN and ISBN Added DateFormatter to LayoutEntry so that it actually works... (JabRef#1619) Converted a few getField to getFieldOptional (JabRef#1625) * Converted a few getField to getFieldOptional Fixed JabRef#636 by using DOICheck and DOIStrip in export filters (JabRef#1624) Improved LaTeX to Unicode/HTML formatters to output more sensible values for unknown commands (JabRef#1622) Updated preview entries (JabRef#1606) * Updated preview entries, which return new entry Moved, removed, and used String constants (JabRef#1618) * Moved, removed, and used String constants * Some more fixes * Moved NEWLINE, made FILE_SEPARATOR public and used it * Moved NEWLINE and FILE_SEPARATOR to OS * Moved ENCODING_PREFIX and SIGNATURE * Corrected Globals in a few comments... * Apparently the localization tests find commented out text... More field names and a method (JabRef#1627) * Introduced FieldName in ArXiV * Some more field names * More field names Cleanup FindFile and asssociated tests (JabRef#1596) * Cleanup FindFile and rework it using Streams and nio methods- * Unignore test for trying on CI * Use explicit List and Set in findFiles and caller methods * Use Lazy Stream to find files changes should be tested manually Some enhancements and cleanups related to dates (JabRef#1575) * Some enhancements and cleanups related to dates * Fixed some time zone issues * Replaced SimpleDateFormat in ZipFileChooser and replaced arrays with Lists * Changed EasyDateFormat constructors * Fixed stupid mistake * Added CHANGELOG entry * Maybe tests are passing now? * Some server side print debugging... * As it should be * Tryng LocalDateTime * No time zone * Added test for Cookie * Fixed imports... * Added a third possible date format as it turns out that the server changed while developing this PR Builds are now stored via build-upload.jabref.org Consistent file name casing (and other localization improvements) (JabRef#1629) * AUX files * ZIP files * BIB files * JAR files * didn't * Couldn't what's * Consistent casing * AUX apparently is commonly used in French words... * Fixed the flawed quick-and-dirty find-and-replace failures define xjc input/ouput dir (subsequent builds will be faster) (JabRef#1628) Execute task only when input/output dir changed. Fixed a minor issue and refactored MergeEntries (JabRef#1634) * Fixed a minor issue and refactored MergeEntries * Fixed import * Added CHANGELOG entry Added LabelPatternPreferences (JabRef#1607) * Added LabelPatternPreferences * Removed static initializer More tests (JabRef#1635) * Added more tests for Cookie * Enabled some layout tests and added test for StringUtil.intValueOfWithNull * Updated a test * Split tests Updated Errorprone to 2.0.11 (JabRef#1636) * Updated Errorprone to 2.0.11 * Corrected test Keep @comment text in a bib file (JabRef#1638) * Kep @comment text in a bib file * Add test for @comment that contains regular entries Replaced some getField and fixed some bugs (JabRef#1631) * Replaced some getField and fixed some bugs * Fixed a few things * Added CHANGELOG entries * Improved equals implementation * Text book equals and hashCode Fixed JabRef#1639 (JabRef#1641) * Fixed JabRef#1639 * Removed old code Export OO/LO citations to new database (JabRef#1630) * Export OO/LO citations to new database * Fixed problem with duplicates * Added some comments * Fixed spelling in comment * Removed general Exception Unified some equals (JabRef#1640) * Unified some equals * Imported correct Objects... Fixed one more NPE which should have been fixed in JabRef#1631 (JabRef#1649) Finished method to hide visible fields and show hidden fields - Hide method done - Show method done - ToDo repaint hidden field - ToDo test class finished field repaint remove sysouts

Braunch added ui stupro labels Mar 17, 2016

koppor force-pushed the master branch from ec2cc84 to 5a1ed8e Compare April 17, 2016 17:54

This was referenced May 4, 2016

Gui testing #507

Merged

Scrollingthroughentrylisttest #1361

Merged

tschechlovdev removed the stupro-ready-for-internal-review label Jun 27, 2016

Braunch force-pushed the changeFocusOnTabSelection branch from 09c07db to cb38595 Compare July 12, 2016 15:53

Braunch changed the title ~~[WIP] When clicking on a tab, the first field now has the focus~~ When clicking on a tab, the first field now has the focus Jul 12, 2016

Braunch added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 12, 2016

tobiasdiez reviewed Jul 13, 2016
View reviewed changes

tobiasdiez removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 13, 2016

Braunch force-pushed the changeFocusOnTabSelection branch 2 times, most recently from a09cf88 to 4864a33 Compare July 19, 2016 11:45

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 19, 2016

Christoph_Br4un added 2 commits July 21, 2016 11:27

he first Field does now have focus when clicking on a tab in the entr…

3a61af6

…y editor

Make first field focused when selecting a tab in entry editor

da81645

Christoph_Br4un and others added 3 commits July 21, 2016 11:27

Reformat code

02ee511

Add the changes to the changelog

84ec712

Fixed import order and strange diffs

9ded2df

Braunch force-pushed the changeFocusOnTabSelection branch from 4864a33 to 9ded2df Compare July 21, 2016 09:41

simonharrer merged commit f30aef3 into JabRef:master Jul 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When clicking on a tab, the first field now has the focus #988

When clicking on a tab, the first field now has the focus #988

Braunch commented Mar 17, 2016 •

edited

Loading

simonharrer commented Mar 17, 2016

Braunch commented Mar 20, 2016

Braunch commented Apr 18, 2016

stefan-kolb commented Jul 12, 2016

Braunch commented Jul 12, 2016

simonharrer commented Jul 12, 2016

Braunch commented Jul 13, 2016

tobiasdiez Jul 13, 2016

tobiasdiez commented Jul 13, 2016

Braunch commented Jul 19, 2016

simonharrer commented Jul 19, 2016

simonharrer commented Jul 19, 2016

Braunch commented Jul 21, 2016

stefan-kolb commented Jul 21, 2016

When clicking on a tab, the first field now has the focus #988

When clicking on a tab, the first field now has the focus #988

Conversation

Braunch commented Mar 17, 2016 • edited Loading

simonharrer commented Mar 17, 2016

Braunch commented Mar 20, 2016

Braunch commented Apr 18, 2016

stefan-kolb commented Jul 12, 2016

Braunch commented Jul 12, 2016

simonharrer commented Jul 12, 2016

Braunch commented Jul 13, 2016

tobiasdiez Jul 13, 2016

Choose a reason for hiding this comment

tobiasdiez commented Jul 13, 2016

Braunch commented Jul 19, 2016

simonharrer commented Jul 19, 2016

simonharrer commented Jul 19, 2016

Braunch commented Jul 21, 2016

stefan-kolb commented Jul 21, 2016

Braunch commented Mar 17, 2016 •

edited

Loading