Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicking on a tab, the first field now has the focus #988

Merged
merged 5 commits into from
Jul 21, 2016
Merged

When clicking on a tab, the first field now has the focus #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a61af6
he first Field does now have focus when clicking on a tab in the entr…
Mar 17, 2016
da81645
Make first field focused when selecting a tab in entry editor
Mar 17, 2016
02ee511
Reformat code
May 3, 2016
84ec712
Add the changes to the changelog
Jun 23, 2016
9ded2df
Fixed import order and strange diffs
Braunch Jul 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,4 +476,4 @@ The changelog of 2.11 and versions before is maintained as [text file](https://g
[3.1]: https://github.com/JabRef/jabref/compare/v3.0...v3.1
[3.0]: https://github.com/JabRef/jabref/compare/v2.11.1...v3.0
[dev_2.11]: https://github.com/JabRef/jabref/compare/v2.11.1...dev_2.11
[2.11.1]: https://github.com/JabRef/jabref/compare/v2.11...v2.11.1
[2.11.1]: https://github.com/JabRef/jabref/compare/v2.11...v2.11.1
Copy link
Member

@tobiasdiez tobiasdiez Jul 13, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange "diff"

5 changes: 3 additions & 2 deletions src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ private void setupFieldPanels() {
otherFields.remove("bibtexkey");
otherFields.removeAll(Globals.prefs.getCustomTabFieldNames());

if(!otherFields.isEmpty()) {
if (!otherFields.isEmpty()) {
addOtherTab(otherFields);
}

Expand Down Expand Up @@ -1026,6 +1026,7 @@ public void stateChanged(ChangeEvent event) {
Object activeTab = tabs.get(tabbed.getSelectedIndex());
if (activeTab instanceof EntryEditorTab) {
((EntryEditorTab) activeTab).updateAll();
activateVisible();
}
});
}
Expand Down Expand Up @@ -1436,7 +1437,7 @@ private void warnDuplicateBibtexkey() {
}

private void warnEmptyBibtexkey() {
panel.output(Localization.lang("Empty BibTeX key")+". "+Localization.lang("Grouping may not work for this entry."));
panel.output(Localization.lang("Empty BibTeX key") + ". " + Localization.lang("Grouping may not work for this entry."));
}


Expand Down