Skip to content

Conversation

@HoussemNasri
Copy link
Member

@HoussemNasri HoussemNasri commented Sep 8, 2025

Fixes #13673

Mandatory checks

@HoussemNasri HoussemNasri added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 8, 2025
Siedlerchr
Siedlerchr previously approved these changes Sep 8, 2025
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
koppor
koppor previously approved these changes Sep 8, 2025
koppor
koppor previously approved these changes Sep 8, 2025
calixtus
calixtus previously approved these changes Sep 8, 2025
@subhramit
Copy link
Member

Just openrewrite is left i think

@subhramit
Copy link
Member

Nope, the logs seem like its that odd prolog error that keeps happening
Let me try merging main once

@subhramit
Copy link
Member

subhramit commented Sep 9, 2025

No change, the error seems to be XML Parse Exception for:
jabref/jablib/src/main/resources/csl-styles/oscola-journal-abbreviations.csl and jabref/jablib/src/main/resources/csl-styles/eu-interinstitutional-style-1st-edition.csl (instead of literatura.csl that appeared in the past).
Under Task :jablib:extractMaintainers

@Siedlerchr
Copy link
Member

Task :rewriteDryRun
Recipe validation error in org.jabref.config.rewrite.cleanup.recipeList[71] (in file:/home/runner/work/jabref/jabref/rewrite.yml): recipe 'org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipe' does not exist.

@HoussemNasri HoussemNasri dismissed stale reviews from koppor and calixtus via 9008a56 September 10, 2025 13:18
return Optional.empty();
}

public static boolean isValueCorrectlyFormatted(String value) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method duplicates logic from checkValue() which violates DRY principle. Should refactor to reuse existing validation logic to prevent maintenance issues.

@koppor koppor added this pull request to the merge queue Sep 10, 2025
Merged via the queue into JabRef:main with commit 577bbb6 Sep 10, 2025
35 of 36 checks passed
Siedlerchr added a commit that referenced this pull request Sep 11, 2025
* upstream/main:
  Fix NoSuchElementException in ThreeWayMerge dialog (#13838)
  Keep global search bar open when  keep on top pin is selected (#13846)
  Spell "BibDesk" with capital "D" (#13847)
  fix: Improper icon sizing with respect to font size (#13841)
  Ensure latest JDK veriant (#13843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught Exception in ThreeWayMerge dialog when looking up Bibliographic information from DOI

5 participants