-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix NoSuchElementException in ThreeWayMerge dialog #13838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...b/src/main/java/org/jabref/logic/bibtex/comparator/YearFieldValuePlausibilityComparator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
...b/src/main/java/org/jabref/logic/bibtex/comparator/YearFieldValuePlausibilityComparator.java
Show resolved
Hide resolved
|
Just openrewrite is left i think |
|
Nope, the logs seem like its that odd prolog error that keeps happening |
|
No change, the error seems to be XML Parse Exception for: |
|
Task :rewriteDryRun |
| return Optional.empty(); | ||
| } | ||
|
|
||
| public static boolean isValueCorrectlyFormatted(String value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method duplicates logic from checkValue() which violates DRY principle. Should refactor to reuse existing validation logic to prevent maintenance issues.
Fixes #13673
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)