Fix Tagsfield in Keyword editor #13858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jabgui/src/test/java/org/jabref/gui/fieldeditors/KeywordsEditorViewModelTest.java
Show resolved
Hide resolved
koppor
reviewed
Sep 11, 2025
jabgui/src/main/java/org/jabref/gui/fieldeditors/KeywordsEditorViewModel.java
Outdated
Show resolved
Hide resolved
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
approved these changes
Sep 11, 2025
Siedlerchr
approved these changes
Sep 11, 2025
Siedlerchr
added a commit
that referenced
this pull request
Sep 12, 2025
* upstream/main: Fix Tagsfield in Keyword editor (#13858)
Siedlerchr
added a commit
that referenced
this pull request
Sep 13, 2025
* upstream/main: New Crowdin updates (#13865) Fix unresponsive "Check Consistency" dialog (#13864) Fix several aux group issues (#13861) Add integrity check to cli (#13848) Add sbom file and remove external libraries (#13859) Fix Tagsfield in Keyword editor (#13858) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13857) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13856)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11390
Follow-up to #10910
The StringConverter seems only to return the parent keyword.
Steps to test
In EntryEditor in source tab add hierarchichal keywords eg "parent > node > child", open general tab and see only parent in keywords, maybe with an assert exception being thrown.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)