Fix unresponsive "Check Consistency" dialog #13864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
previously approved these changes
Sep 12, 2025
subhramit
approved these changes
Sep 12, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
added a commit
that referenced
this pull request
Sep 13, 2025
* upstream/main: New Crowdin updates (#13865) Fix unresponsive "Check Consistency" dialog (#13864) Fix several aux group issues (#13861) Add integrity check to cli (#13848) Add sbom file and remove external libraries (#13859) Fix Tagsfield in Keyword editor (#13858) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13857) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13856)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13700
I'm yet to investigate deeply the root cause behind this, it could be a JavaFX bug in ProgressDialog#showAndWait or a bug in our DialogService. The bug happens because for some reason the progress dialog, although it becomes invisible, it does not fully shutdown and keeps being on top of the app preventing interaction with underlying UI.
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)