-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Make Web Search 'Configure API key' searchable in preferences #13929 #13982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Web Search 'Configure API key' searchable in preferences #13929 #13982
Conversation
Hey @OmkarNagare16!Thank you for contributing to JabRef! Your help is truly appreciated ❤️. We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
jabgui/src/main/java/org/jabref/gui/preferences/PreferencesSearchHandler.java
Show resolved
Hide resolved
|
lgtm, just add a changelog entry and it's good to go. |
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - Made "Configure API key" option in the Web Search preferences tab searchable via preferences search. [#13929](https://github.com/JabRef/jabref/issues/13929) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Made "Configure API key" option in the Web Search preferences tab searchable via preferences search. [#13929](https://github.com/JabRef/jabref/issues/13929) | |
| - We made the "Configure API key" option in the Web Search preferences tab searchable via preferences search. [#13929](https://github.com/JabRef/jabref/issues/13929) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @subhramit , I’ve just updated the changelog as suggested. Thanks for the review! Please let me know if there’s anything else.
|
@trag-bot didn't find any issues in the code! ✅✨ |
…13929 (JabRef#13982) * Make Web Search 'Configure API key' searchable in preferences * Fix Checkstyle empty line issues in PreferencesTab and WebSearchTab * Trigger CI after updating PR description * Fix failing LocalizationConsistencyTest: add missing 'Custom API key' entry * Add changelog entry for searchable API key preferences * Fix list formatting in changelog * Move changelog entry to Unreleased section * Trigger CI * Update changelog wording based on reviewer suggestion
…13929 (JabRef#13982) * Make Web Search 'Configure API key' searchable in preferences * Fix Checkstyle empty line issues in PreferencesTab and WebSearchTab * Trigger CI after updating PR description * Fix failing LocalizationConsistencyTest: add missing 'Custom API key' entry * Add changelog entry for searchable API key preferences * Fix list formatting in changelog * Move changelog entry to Unreleased section * Trigger CI * Update changelog wording based on reviewer suggestion
Closes #13929
This PR adds the ability to search for the "Configure API key" option in the Web Search preferences tab
Changes
WebSearchTab.javato add search keywords such as "Configure API key", "Custom API key", "api", "api key", "apikey"PreferencesTab.javato include a defaultgetSearchKeywords()methodPreferencesSearchHandler.javato consider keywords when filtering tabsWith this change, users can quickly find the "Configure API key" option by typing relevant search terms in the preferences search bar
Steps to Test
Visual Reference
Mandatory checks
CHANGELOG.md