Fix NPE on startup #14272
Merged
Fix NPE on startup #14272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Nov 9, 2025
Member
|
Tried the PR. Still ... |
Member
|
try with -d all https://docs.jabref.org/advanced/commandline for resetting the prefs |
Member
Author
We should know where it crashes to fix the issue - and not be forced to tell all users that they should reset their preferences. |
Member
Author
|
To replicate the issue: --- a/jabgui/src/main/java/org/jabref/gui/JabRefGUI.java
+++ b/jabgui/src/main/java/org/jabref/gui/JabRefGUI.java
@@ -109,6 +109,10 @@ public class JabRefGUI extends Application {
dialogService.showErrorDialogAndWait("Uncaught exception occurred in " + thread, exception);
}));
+ if (1 == 1) {
+ throw new RuntimeException();
+ }
+
initialize();
JabRefGUI.mainFrame = new JabRefFrame( |
Member
Author
|
DevChat: @ThiloteE needs to check. He needs to do other work. I put him as assignee to make it transparent that we wait for his input. |
Member
|
Tried 3c17fdb If we can fix this issue it's better than telling all users having to reset their preferences. I think reseting prefs should only be the last resort. |
5 tasks
Member
|
ERROR: Error during initialization: java.lang.IllegalArgumentException: No enum constant org.jabref.logic.importer.plaincitation.PlainCitationParserChoice.RULE_BASED |
Member
Author
|
No changelog, because issue introduced after release. |
Siedlerchr
approved these changes
Nov 10, 2025
Siedlerchr
added a commit
that referenced
this pull request
Nov 10, 2025
* main: Fix NPE on startup (#14272)
Member
|
Can confirm, it works now. I can start JabRef again with this PR. |
Siedlerchr
added a commit
that referenced
this pull request
Nov 13, 2025
* upstream/main: Fix NPE on startup (#14272)
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
* Try to get logging running again * Remove use of Map for configuration * Fix exception * Try to log Exceptions * Revert "Try to get logging running again" This reverts commit 89b846f. * Fix exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one system we have
Without any more output
Breaking commit was found via manual git bisect.
Good commit: e6ceac8
First bad commit: 0dc6dd7
More logging needs to be done "manually":
gluonhq/client-samples#12 (comment)
Follow-up to #14233
CC @InAnYan - by renaming the citation constants, reading preferences caused an NPE.
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)