-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Initial framework for jablib-examples #14233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- BibliographyFromPdfImporter is also an PdfImporter - importDatabase returns ParserResult (for consistency)
(and fix BibligraphyFromPdfImporter method use)
| return CitationSplitter.splitCitations(text) | ||
| .map(Unchecked.function(this::parsePlainCitation)) | ||
| .flatMap(Optional::stream) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .collect(Collectors.toList()); | |
| .toList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, just in time 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow-up :)
* Initial framework for jablib-examples * Rename "serializeAll" to "writeAll" * Add some `@NonNull` annotations * Even more consistent * More renamings * Add convenience constructor * Add some nullable annotations * Add cross-links * Fix typo * Fix class name * Have BibliographyFromPdfImporter implementing PlainCitationParser * Add "IEEE" as another rule option * Fix method name (and visibility) * Compilefix * Fix casing in BibTeX * Enable LLM to be used to parse references * Refine code - BibliographyFromPdfImporter is also an PdfImporter - importDatabase returns ParserResult (for consistency) * Move pdf related importers to pdf sub package * Initial PdfImporterWithPlainCitationParser * WIP: ieee_pdf_references_to_bibtex * Add link to CHANGELOG.md * Refine PlainCitationParser interface * Move methods to PdfUtils * Make LlmPlainCitationParser a real importer (and fix BibligraphyFromPdfImporter method use) * Add missing class * Wire all availble importers * Rename BibliographyFromPdfImporter to RuleBasedBibliographyPdfImporter * Introdue intermediate class BibliographyFromPdfImporter * Fix PdfGrobitImporter (to really extract the references) * Add comment * Fix JavaFX graphics dependency in ProgressCounter * Remove routing method * Remove obsolete test file * Add development hint to README.md * First version of to BibTeX conversion * Adapt test to new behavior * Apply format * Fix NullAway warning * Fix Moderinzer * Refine checkstyle supressions * Fix typo * Use release version of action-checkstyle * Move complete file ignores to checkstyle.xml * Also run if jbang scripts themselves have changed * Add link * Update checkstyle version in checkstyle-idea.xml * Remove obsolete comment * Apply suggestions from code review Co-authored-by: Ruslan <ruslanpopov1512@gmail.com> * Fix checkstyle * Increase IntelliJ version * Switch to other formatter * Fix checkstyle * Fix reference * Apply renaming also in script * Fix jbang build command (double .java) * Workaround for formatter issue * Switch back to other formatter (better output) * Remove one more ".java" * Try to list all files * Rename "simple" to "general" * Debug: output modified files * Add missing } * Try other way for debugging * Ohter debug * Fix debug * Fix copy and paste error * Output script * Remove obsolete ".java" * Remove debug * Remove "build" * Fix source adaption * Refine tests * Better grouping --------- Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Ruslan <ruslanpopov1512@gmail.com>
With the modularization we got "jablib". Now, its time to offer it as "useful" library.
I tried to write some scripts in JBang, but the API of JabRef was less than OKish, so I refactored.
Aim for this PR:
DOI to BibTeX--> follow-up PRAdditional Changes
IEEE as explicit rule-based parser available
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)