Replaced output of getResolvedField to Optional<String> #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
component: cleanup-ops
status: ready-for-review
| @@ -268,38 +261,37 @@ private String handleOptionField(BibEntry bibtex, BibDatabase database) { | |||
| } | |||
|
|
|||
| private String handleFieldOrGroupStart(BibEntry bibtex, BibDatabase database, Optional<Pattern> highlightPattern) { | |||
| String field; | |||
| Optional<String> field; | |||
| if (type == LayoutHelper.IS_GROUP_START) { | |||
| field = BibDatabase.getResolvedField(text, bibtex, database); | |||
| } else if (text.matches(".*(;|(\\&+)).*")) { | |||
There was a problem hiding this comment.
A great improvement would be to compile the regexes to pattern (Pattern.compile(regex) and then use simply
split() on that pattern object , otherwise java creates each regex pattern everytime again.
(I did not know that until I just found it in javadoc 😎 )
https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html#split-java.lang.CharSequence-
There was a problem hiding this comment.
Sure. Create an issue in koppor/JabRef. ;-)
There was a problem hiding this comment.
28 hits of matches("
There was a problem hiding this comment.
Maybe that is time for another PR.
|
LGTM |
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Aug 5, 2016
* master: Fixed OO/LO manual connection dialog on Linux Removed thrown Exception declarations (JabRef#1673) Fix JabRef#1288 Newly opened bib-file is not focused (JabRef#1671) Refactor DB loading Fix OutOfBoundsException when importing multiple entries in medline format (JabRef#1611) Removed the possibility to auto show or hide the groups interface (JabRef#1668) Add test to describe workaround for JabRef#1633 Fixed JabRef#1643: Searching with double quotes in a specific field ignores the last character fix build Fixes JabRef#1554: JabRefFrame is set as owner for ImportInspectionDialog Fixed most of the ErrorProne warnings Replaced output of getResolvedField to Optional<String> (JabRef#1650) PushToApplication cleanup and refactoring (JabRef#1659) Replaced Object with appropriate class where possible (JabRef#1660) Replaced some array return types (JabRef#1661) Fix XMP test Localization Moved the main part of XMPUtil to jabref.XMPUtilMain and injected a b… (JabRef#1642) Made possible to make the OO/LO panel a bit more narrow (JabRef#1652) French localization: Jabref_fr: empty strings + some cleaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit weird that there are no explicit tests at all for
getResolvedField...