Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1288 Newly opened bib-file is not focused #1671

Merged
merged 2 commits into from
Aug 4, 2016
Merged

Fix #1288 Newly opened bib-file is not focused #1671

merged 2 commits into from
Aug 4, 2016

Conversation

stefan-kolb
Copy link
Member

@stefan-kolb stefan-kolb commented Aug 3, 2016 •
edited
Loading

  • Open a NEW file and it is correctly focused afterwards
  • Open a file that was already OPENED before is correctly focused afterwards
  • Open a file TWO TIMES and it is only opened once

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 3, 2016
@matthiasgeiger matthiasgeiger removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 3, 2016
@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 3, 2016
@stefan-kolb
Copy link
Member Author

@matthiasgeiger Should work now 😄

@matthiasgeiger
Copy link
Member

LGTM (apart from the minor comments via Skype 😉 )

@stefan-kolb stefan-kolb merged commit e95c9bd into master Aug 4, 2016
@stefan-kolb stefan-kolb deleted the raise-panel branch August 4, 2016 09:04
Siedlerchr added a commit to Siedlerchr/jabref that referenced this pull request Aug 5, 2016
@Siedlerchr
Merge branch 'master' into fileChooserRefactor
c974ae1 
* master:
  Fixed OO/LO manual connection dialog on Linux
  Removed thrown Exception declarations (JabRef#1673)
  Fix JabRef#1288 Newly opened bib-file is not focused (JabRef#1671)
  Refactor DB loading
  Fix OutOfBoundsException when importing multiple entries in medline format (JabRef#1611)
  Removed the possibility to auto show or hide the groups interface (JabRef#1668)
  Add test to describe workaround for JabRef#1633
  Fixed JabRef#1643: Searching with double quotes in a specific field ignores the last character
  fix build
  Fixes JabRef#1554: JabRefFrame is set as owner for ImportInspectionDialog
  Fixed most of the ErrorProne warnings
  Replaced output of getResolvedField to Optional<String> (JabRef#1650)
  PushToApplication cleanup and refactoring (JabRef#1659)
  Replaced Object with appropriate class where possible (JabRef#1660)
  Replaced some array return types (JabRef#1661)
  Fix XMP test
  Localization
  Moved the main part of XMPUtil to jabref.XMPUtilMain and injected a b… (JabRef#1642)
  Made possible to make the OO/LO panel a bit more narrow (JabRef#1652)
  French localization: Jabref_fr: empty strings + some cleaning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefan-kolb @matthiasgeiger