Improve focus of the maintable after a sidepane gets closed #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairdl
changed the title
| @@ -104,6 +104,8 @@ public synchronized void hide(String name) { | |||
| LOGGER.warn("Side pane component '" + name + "' unknown."); | |||
| } else { | |||
| hideComponent(sidePaneComponent); | |||
| frame.getCurrentBasePanel().getMainTable().setSelected(frame.getCurrentBasePanel().getMainTable().getSelectedRow()); | |||
| frame.getCurrentBasePanel().getMainTable().requestFocus(); | |||
There was a problem hiding this comment.
Please extract frame.getCurrentBasePanel().getMainTable() to new local variable.
|
Please add a Changelog entry |
|
I put your feedback into my code. |
| @@ -12,6 +12,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
| - Improve focus of the maintable after a sidepane gets closed | |||
There was a problem hiding this comment.
Please move it to the end of the Fixed section and describe the bug
mairdl
force-pushed
the
ImproveNewHotkeySystem
branch
from
70e33b9
to
413313a
Compare
tschechlovdev
added
status: ready-for-review
mairdl
changed the title
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Aug 18, 2016
* master: Fix imports Rename NewFileDialog -> FileDialog Also cancel duplicate finder workflow on close button Removed/moved preferences which are constants implements JabRef#1767: Add Help Button to access new help page Fixed BibTeXMLImporter Set more default file filters in dialogs JabRef#1763 Resolve crossrefs and strings in main table (JabRef#1644) Rewrite bibtexml importer with JAXB parser (JabRef#1666) Moved a few more initialization to GUIGlobals.init() (JabRef#1756) Added program to generate a table of all characters and fixed some characters (JabRef#1766) Improve focus of the maintable after a sidepane gets closed (JabRef#1741) Table row height adjusts on Windows as the font scales with the menu (JabRef#1623) Added more characters to converters (JabRef#1761)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1525
The minimum quality is achieved: The new system is better then the old one.
Some issues remain, which i try to improve in this PR. Also thanks to @koppor for finding these and even providing a .gif.
Focus of "new database" instead of entry.
Expectation: When I toggle something, the focus after toggling twice should be the same. This is not the case.
Sometimes, this happens after step 4, but not reproducable.
Position in entry table
(updated)
The position in the entry table changes depended of the selected group.
Expected behavior: When I select the third entry, show the groups interface, hide the groups interface, press cursor up, the entry above the current entry should be shown.
Example:
complex.bibJust play around a bit with "complex.bib"