Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added program to generate a table of all characters and fixed some ch… #1766

Merged
merged 4 commits into from
Aug 18, 2016

Conversation

oscargus
Copy link
Contributor

I made a small program that generates a LaTeX table with all characters in the converter. It prints the number, the character as Unicode \symbol{nnn}, the resulting LaTeX symbol, and the LaTeX code, see the attached file. In this way, we can make sure that all symbols makes sense (some of the current one were incorrect). Also relates to #1761 which is not currently included.

I note two thing:

  1. using \usepackage[utf8]{inputenc} did only work for accented characters. I had a version where I printed the Unicode character in the table, but that only rarely worked, although they appeared nicely in the .tex-file
  2. Packages and fonts are a bit of a mystery. It may be that with a better font and maybe a few more packages, more symbols are shown.
    CharGen5.pdf
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@oscargus oscargus added type: feature status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Aug 17, 2016
@oscargus
Copy link
Contributor Author

oscargus commented Aug 17, 2016

Updated version with Unicode characters as well. Clearly it is some sort of font issue.
CharGen5.pdf (Updated with a better font.)

@oscargus
Copy link
Contributor Author

Would it be feasible to run this program and compile the resulting tex file as part of the tests? If no compilation errors, all symbols are at least syntactically correct.

@tobiasdiez
Copy link
Member

You can probably add it to the build script. The following links might be helpful:
https://gist.github.com/LindsayBradford/11274456
https://github.com/mgmax/pdflatex-travis-example

@koppor
Copy link
Member

koppor commented Aug 18, 2016

The tex file needs too much packages and might take a long time to get texlive running at each test.

@koppor koppor merged commit 20c1302 into JabRef:master Aug 18, 2016
@oscargus oscargus deleted the characterlist branch August 18, 2016 08:16
Siedlerchr added a commit to Siedlerchr/jabref that referenced this pull request Aug 18, 2016
* master:
  Fix imports
  Rename NewFileDialog -> FileDialog
  Also cancel duplicate finder workflow on close button
  Removed/moved preferences which are constants
  implements JabRef#1767: Add Help Button to access new help page
  Fixed BibTeXMLImporter
  Set more default file filters in dialogs JabRef#1763
  Resolve crossrefs and strings in main table (JabRef#1644)
  Rewrite bibtexml importer with JAXB parser (JabRef#1666)
  Moved a few more initialization to GUIGlobals.init() (JabRef#1756)
  Added program to generate a table of all characters and fixed some characters (JabRef#1766)
  Improve focus of the maintable after a sidepane gets closed (JabRef#1741)
  Table row height adjusts on Windows as the font scales with the menu (JabRef#1623)
  Added more characters to converters (JabRef#1761)
ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
…aracters (JabRef#1766)

* Added program to generate a table of all characters and fixed some characters

* Improved the generation

* Added some more characters

* More characters and better verb character
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants