Rewrite Bibtexml exporter #2017
Conversation
tschechlovdev
changed the title
tschechlovdev
force-pushed
the
fix-bibtexml-export
branch
from
ef200d1
to
b9980ac
Compare
| import org.apache.commons.logging.Log; | ||
| import org.apache.commons.logging.LogFactory; | ||
|
|
||
| public class BibTeXMLExportFormat extends ExportFormat { |
There was a problem hiding this comment.
Please add a javadoc comment.
| Marshaller marshaller = context.createMarshaller(); | ||
| marshaller.setProperty(Marshaller.JAXB_FORMATTED_OUTPUT, Boolean.TRUE); | ||
|
|
||
| marshaller.marshal(file, new java.io.File(resultFile)); |
There was a problem hiding this comment.
Wrong import or why do you need java.io.File here?
There was a problem hiding this comment.
not wrong, but there is also a class File that is generated by JAXB. Thats is why this is needed.
| } | ||
|
|
||
| /** | ||
| * Contains same logic as the parse method, but inbook needs a special treatment, because |
There was a problem hiding this comment.
If it contains the same logic, please use a {@link} annotation.
| editor = {Maxima Musterfrau}, | ||
| volume = {1}, | ||
| number = {1}, | ||
| chapter = {3}, |
There was a problem hiding this comment.
Is this intentionally not being exported or is it missing in the exported xml file?
There was a problem hiding this comment.
Yeah, this is intentionally, because the schema doesn't have something like chapter in the InCollection type.
| <file xmlns="http://bibtexml.sf.net/"> | ||
| <entry id="Mustermann2016"> | ||
| <inbook> | ||
| <bibtexkey>Mustermann2016</bibtexkey> |
There was a problem hiding this comment.
Why is it beeing exported to a new node here but not in the previous test files?
There was a problem hiding this comment.
Only inbook has the field key, that can be set. You can look at the generated Inbook class, there's a field key. Also in the other test for Inbook there's a bibtexkey as well.
|
Regarding the parameterized tests, something seems to be wrong with the path of the resource files because when I run the test class in IntelliJ it doesn't show any executed tests. For me the following classes are affected: I think it is best to move this issue to a new pr. |
| @@ -141,7 +140,7 @@ private void createMarshallerAndWriteToFile(File file, String resultFile) throws | |||
| } | |||
|
|
|||
| /** | |||
| * Contains same logic as the parse method, but inbook needs a special treatment, because | |||
| * Contains same logic as the {@link parse()} method, but inbook needs a special treatment, because | |||
There was a problem hiding this comment.
To link to a method you need to use the following annotation {@link #parse()}, But the rest is good to me.
boceckts
added
status: ready-for-review
* rewrite exporter with jaxb parser * add test * fix codacy and some code refactorings * delete old layout files * adress comments
Since the importer is written with a JAXB parser, I've rewritten the exporter with a jaxb parser as well. The exporter is now written in a similar way to the importer.
This should also fix #1337.