Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of percentage symbol in entry preview #3149

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

tobiasdiez
Copy link
Member

Having \% in some of the fields, it was displayed as % in the entry preview. For some reason the HTML display was not able to correctly handle this HTML code (probably because it uses IE's rendering).
This issue was reported at #3148 (comment).

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 23, 2017
@Siedlerchr Siedlerchr merged commit 47b949a into master Aug 23, 2017
@Siedlerchr Siedlerchr deleted the fixPercentageSymbolInPreview branch August 23, 2017 13:24
Siedlerchr added a commit that referenced this pull request Aug 24, 2017
* upstream/master:
  Fix errorprone (#3151)
  Fix display of percentage symbol in entry preview (#3149)
Siedlerchr added a commit that referenced this pull request Aug 27, 2017
* upstream/master:
  Add preference to disable validation in the entry editor by default (#3154)
  Fix freezing on browse in protected terms dialog when adding from entry editor (#3158)
  Close entry editor when the shown entry is removed externally (#3156)
  .jar are not ignored any more (#3155)
  Increase size of file and keywords editors (#3141)
  Make Replace Strings work in bibtexkeyfield
  Fix errorprone (#3151)
  Fix display of percentage symbol in entry preview (#3149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants