Add preference to disable validation in the entry editor by default #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenhard
added
the
status: ready-for-review
tobiasdiez
requested changes
Aug 25, 2017
| public class EditorValidator { | ||
|
|
||
| public static void configureValidation(ValidationStatus status, EditorTextArea area) { | ||
| if (Globals.prefs.getBoolean(JabRefPreferences.VALIDATE_IN_ENTRY_EDITOR)) { |
There was a problem hiding this comment.
Can you please not use Globals.prefs. I really tried hard to make the JavaFX stuff free of Globals. You can simply pass a preference instance to the editor (similar how it is done in the OwnerEditor) and then to this method here (mabye as new EntryValidator(preferences).configureValidation(...))).
There was a problem hiding this comment.
Done! Good point also, we should thrive to keep this independent from Globals. I even spotted one more usage in FieldEditors that you seem to have overlooked ;-)
# Conflicts: # src/main/java/org/jabref/gui/fieldeditors/FieldEditors.java
|
Since the review comments have been addressed and for the sake of getting things done, I am merging this now. |
Siedlerchr
added a commit
that referenced
this pull request
Aug 27, 2017
* upstream/master: Add preference to disable validation in the entry editor by default (#3154) Fix freezing on browse in protected terms dialog when adding from entry editor (#3158) Close entry editor when the shown entry is removed externally (#3156) .jar are not ignored any more (#3155) Increase size of file and keywords editors (#3141) Make Replace Strings work in bibtexkeyfield Fix errorprone (#3151) Fix display of percentage symbol in entry preview (#3149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a preference option for enabling/disabling validation in the entry editor: #3100 (but not the UI)
The reason is because the validation is simply broken at the moment #3145
The preference option is set to false by default and there is no UI to change it. So this turns off validation in the entry editor. We can add the UI to turn it on later, when the display bug in controlsfx has been fixed.
When this is merged, the related issues can be removed from the 4.0 milestone.
gradle localizationUpdate?