Don't report journal name as abbreviated when full name = abbreviated name

[tobiasdiez]

Fixes #4115.

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[stefan-kolb]

I was thinking about this yesterday, too.
Your solution is fine, although it changes the logic of the abbreviation repository in a way that in not 100% intuitive.
What do you think about handling those false positives in the checker instead, so the repository logic stays pure, i.e.:
In the checker,

• check if abbreviation is found
• if abbreviation == long form no warning
• else warning

[tobiasdiez]

Thanks for the feedback. Your solution was my initial idea but then went on to modify the JournalRepository because other (potential) callers of the repository also profit from the change. I wouldn't consider "Bioinformatics" abbreviated when it's also the full journal name (which is of course a question of definition).

In the end it's almost a question of taste and I'm also fine changing it to your solution (if you think the additional work is worth it ;-) ).

[stefan-kolb]

That was exactly my thought too (that Bioinformatics is no abbreviation of bioinformatics), but then we should rather cleanup the list than the code?! But then I thought, ok they want to have this journal in there...