Fix error prone warnings #4290
Merged
Fix error prone warnings #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a few things found by error prone.
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
reviewed
Aug 23, 2018
| @@ -155,8 +155,8 @@ private static boolean isFxmlFile(Path path) { | |||
| for (String key : keys) { | |||
| result.add(new LocalizationEntry(path, key, type)); | |||
| } | |||
| } catch (IOException ignore) { | |||
| ignore.printStackTrace(); | |||
| } catch (IOException exception) { | |||
There was a problem hiding this comment.
Why throwing a Runtime Exception?`
There was a problem hiding this comment.
Because we don't really care about the exception (it should never occur) but the tests should fail nonetheless if an exception occurs. Moreover, these methods here used while working with (file) streams, which does not has a nice mechanism to handle exceptions.
LinusDietz
approved these changes
Aug 28, 2018
Siedlerchr
added a commit
that referenced
this pull request
Aug 29, 2018
* upstream/master: Fix error prone warnings (#4290) Fix freeze on import into current library (#4299) Upgrade gradle to 4.10 update xmlunit and postgres update xmlunit-matchers from 2.6.0 -> 2.6.1 update gradle build-scan from 1.15.2 -> 1.16 checkstyle execute changes only if disk db present fix npe in Merge entries dialog
Siedlerchr
added a commit
that referenced
this pull request
Aug 29, 2018
* upstream/master: (468 commits) Fix error prone warnings (#4290) Fix freeze on import into current library (#4299) Upgrade gradle to 4.10 update xmlunit and postgres update xmlunit-matchers from 2.6.0 -> 2.6.1 update gradle build-scan from 1.15.2 -> 1.16 checkstyle execute changes only if disk db present Fix Export to clipbaord action (#4286) fix npe in Merge entries dialog Add minimal height for entry editor (#4283) Fix exceptions when trying to change settings (#4284) Added a comment for the purpose of the class (#4282) Fix NPE when importing from CLI (#4281) Fix display of key patterns convert bibtexkeypatterndlg to javafx as well (#4277) Style preference sections using css Fix a few style issues Changed the behavior of the field formatting dialog (#4275) Fix checkbox display Remove small font size ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few things found by error prone.