Fix error prone warnings

src/test/java/org/jabref/logic/importer/fileformat/BibtexParserTest.java

@@ -47,8 +47,8 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -1172,7 +1172,7 @@ void parsePreambleAndEntryWithoutNewLine() throws IOException {
     @Test
     void parseFileHeaderAndPreambleWithoutNewLine() throws IOException {
         ParserResult result = parser
-                .parse(new StringReader("% Encoding: US-ASCII@preamble{some text and \\latex}"));
+                .parse(new StringReader("\\% Encoding: US-ASCII@preamble{some text and \\latex}"));
 
         assertFalse(result.hasWarnings());
         assertEquals(Optional.of("some text and \\latex"), result.getDatabase().getPreamble());

src/test/java/org/jabref/logic/l10n/LocalizationConsistencyTest.java

@@ -12,16 +12,21 @@
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Properties;
+import java.util.ResourceBundle;
 import java.util.Set;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class LocalizationConsistencyTest {
@@ -140,6 +145,31 @@ void localizationParameterMustIncludeAString() throws IOException {
         }
     }
 
+    private static Language[] installedLanguages() {
+        return Language.values();
+    }
+
+    @ParameterizedTest
+    @MethodSource("installedLanguages")
+    void resourceBundleExists(Language language) {
+        Path messagesPropertyFile = Paths.get("src/main/resources").resolve(Localization.RESOURCE_PREFIX + "_" + language.getId() + ".properties");
+        assertTrue(Files.exists(messagesPropertyFile));
+    }
+
+    @ParameterizedTest
+    @MethodSource("installedLanguages")
+    void languageCanBeLoaded(Language language) {
+        Locale oldLocale = Locale.getDefault();
+        try {
+            Locale locale = Language.convertToSupportedLocale(language).get();
+            Locale.setDefault(locale);
+            ResourceBundle messages = ResourceBundle.getBundle(Localization.RESOURCE_PREFIX, locale, new EncodingControl(StandardCharsets.UTF_8));
+            assertNotNull(messages);
+        } finally {
+            Locale.setDefault(oldLocale);
+        }
+    }
+
     private static class DuplicationDetectionProperties extends Properties {
 
         private static final long serialVersionUID = 1L;

src/test/java/org/jabref/logic/l10n/LocalizationParser.java

@@ -155,8 +155,8 @@ private static List<LocalizationEntry> getLanguageKeysInJavaFile(Path path, Loca
             for (String key : keys) {
                 result.add(new LocalizationEntry(path, key, type));
             }
-        } catch (IOException ignore) {
-            ignore.printStackTrace();
+        } catch (IOException exception) {
+            throw new RuntimeException(exception);
         }
 
         return result;
@@ -174,8 +174,8 @@ private static List<LocalizationEntry> getLocalizationParametersInJavaFile(Path
             for (String key : keys) {
                 result.add(new LocalizationEntry(path, key, type));
             }
-        } catch (IOException ignore) {
-            ignore.printStackTrace();
+        } catch (IOException exception) {
+            throw new RuntimeException(exception);
         }
 
         return result;
@@ -209,15 +209,16 @@ public boolean containsKey(String key) {
 
         PlatformImpl.startup(() -> {
         });
+
         try {
             FXMLLoader loader = new FXMLLoader(path.toUri().toURL(), registerUsageResourceBundle);
             // We don't want to initialize controller
             loader.setControllerFactory(controllerType -> null);
             // Don't check if root is null (needed for custom controls, where the root value is normally set in the FXMLLoader)
             loader.impl_setStaticLoad(true);
             loader.load();
-        } catch (IOException ignore) {
-            ignore.printStackTrace();
+        } catch (IOException exception) {
+            throw new RuntimeException(exception);
         }
 
         return result.stream()

src/test/java/org/jabref/model/strings/StringUtilTest.java

@@ -120,7 +120,7 @@ void testShaveString() {
 
     @Test
     void testJoin() {
-        String[] s = "ab/cd/ed".split("/");
+        String[] s = {"ab", "cd", "ed"};
         assertEquals("ab\\cd\\ed", StringUtil.join(s, "\\", 0, s.length));
 
         assertEquals("cd\\ed", StringUtil.join(s, "\\", 1, s.length));