Fixed preview not showing issue for an entry properly

[harinda05]

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[tobiasdiez]

Thanks for your contribution. I've problems parsing and understanding the changes and would welcome if you could explain them a bit.

[tobiasdiez]

I don't understand this change. Here we react to the user selecting a different entry. For me it is not clear why we need to show or hide the preview in this case (if it already shown, then we don't need to show it; and if it was not shown then it also shouldn't be shown just because the user selects a different entry).

Can you please explain the reason for this change. Thanks!

[harinda05]

`private void setPreviewAction() {
PreviewPreferences previewPreferences = Globals.prefs.getPreviewPreferences();
boolean enabled = previewPreferences.isPreviewPanelEnabled();
PreviewPreferences newPreviewPreferences = previewPreferences.getBuilder()
.withPreviewPanelEnabled(enabled)
.build();
Globals.prefs.storePreviewPreferences(newPreviewPreferences);
setPreviewActive(enabled);
}

It gets the current value of whether the preview panel is enabled or disabled. And if enabled the preview is shown. the setPreviewActive(enabled); method call is the part which is responsible for showing the preview and the panel in the UI (previous logic)

` private void setPreviewOn(Boolean previewOn) {
PreviewPreferences previewPreferences = Globals.prefs.getPreviewPreferences();
PreviewPreferences newPreviewPreferences = previewPreferences.getBuilder()
.withPreviewPanelEnabled(previewOn)
.build();
Globals.prefs.storePreviewPreferences(newPreviewPreferences);

}`

This method only sets the panel to be enabled. But it's not yet shown in the UI. since setPreviewActive(enabled); is not called in this method.

Thus;

At the beginning by calling setPreviewOn() method enables the preview panel (Not shown in the UI) and the when a row is clicked setPreviewAction() method is called and based on whether the panel is active or not (Panel can be disabled by clicking on the menu item) the preview is shown or not.

[tobiasdiez]

Now the preview is always shown?

[harinda05]

Yes at the beginning only the preference is set to be true but it's not shown until a row is pressed. As per previous logic, the preview entry in menu is ticked when the program loads but it does not show any preview even a row is clicked.

[harinda05]

@tobiasdiez Any specific ideas about this?

[tobiasdiez]

I have to admit, that I still don't really get these changes. Maybe one of the other @JabRef/developers is more familiar with the code related to previews.

[LinusDietz]

We are not quite sure where this PR is going.