Include preview in entry editor #4976

tobiasdiez · 2019-05-17T16:38:20Z

First shot at #2115. Current look:

@JabRef/developers @mlep @grimes2
Should I continue along this path, or do we need a different solution?

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez · 2019-05-31T20:22:44Z

@JabRef/developers I would like to have your opinions about this solution before doing the major code changes necessary for a complete integration.

matthiasgeiger · 2019-06-01T10:59:01Z

@tobiasdiez I'm a bit indifferent.
First: personally I do not really use the preview function at all. I'm using standard natbib or whatever styles in LaTeX and therefore know how the entries will be looking like (or I'm not really interested in the exact way they are looking).

Therefore, I'm not sure whether I like it that much screenspace is "wasted" in the entry editor for the required fields tabs. However, I think for persons who are interested in the preview this might be even better than the older style.

So, for me it is okay to have in the entry editor - but it should still be possible to disable/hide the preview in case you are not interested in the information shown there.

Abbreviates isDateTag() and getDatePriority()

…Contextmenu * upstream/master: (21 commits) Bump junit-vintage-engine from 5.4.2 to 5.5.0 Bump log4j-api from 2.11.2 to 2.12.0 Bump junit-platform-launcher from 1.4.2 to 1.5.0 Bump log4j-core from 2.11.2 to 2.12.0 Bump log4j-slf4j18-impl from 2.11.2 to 2.12.0 Bump log4j-jul from 2.11.2 to 2.12.0 Bump junit-jupiter from 5.4.2 to 5.5.0 Bump com.github.johnrengelman.shadow from 5.0.0 to 5.1.0 Bump log4j-jcl from 2.11.2 to 2.12.0 Bump fontbox from 2.0.15 to 2.0.16 (#5080) Bump pdfbox from 2.0.15 to 2.0.16 (#5081) Bump xmpbox from 2.0.15 to 2.0.16 (#5082) Update FUNDING.yml Delete autoapproval.yml Bump com.install4j.gradle from 7.0.11 to 7.0.12 (#5077) Configure autoapproval plugin for dependabot Bump xmlunit-matchers from 2.6.2 to 2.6.3 (#5074) Bump checkstyle from 8.21 to 8.22 (#5072) Bump xmlunit-core from 2.6.2 to 2.6.3 (#5073) Refactor for loop to stream in groupTree Close version socket ...

Add copy linked files action to contextmneu in general tab

…ew_mvvm

Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 3.0.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v2.28.2...v3.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…ew_mvvm

Allow negation (`!`, NOT operator) in \\begin{...} conditionals

* Fix lookup entry types in enums Make master work again!!! * fix checkstyle * fix checkstyle and fix type comparison to lower case * simplify remove generics

Co-Authored-By: Oliver Kopp <kopp.dev@gmail.com>

If we create journal abbrev files via the JabRef, they are saved in UTF-8. So it makes sense to use this as default encoding. Also see #5133.

Co-authored-by: Linus Dietz <linus@lynyus.de>

…o includePreview

…o include-preview

Co-authored-by: Stefan Kolb <stefan-kolb@web.de>

LinusDietz · 2019-08-24T15:04:56Z

Superseded by #5218

AEgit · 2019-08-25T12:17:21Z

I know this is a big thing to ask but can you please revert this change and/or make it just optional. I have just had a look at JabRef 5.0-alpha--snapshot--2019-08-25--master--0c342bdc7 to test #4808 (comment) just to realise that the entry preview is no longer automatically shown at all.

I am heavily reliant on using the entry preview. I often tend to quickly go through different entries and the entry preview gives me a quick overview of the entry. Now I always have to open the entry editor just to see the preview. My feeling is, that this change was introduced by people who actually do not even use the entry preview at all (see also comment here: #4976 (comment)). This new behaviour is completely different from the old JabRef behaviour and from similar reference managers (e.g., Mendeley).
So, unless you can suggest a change in the way I should use JabRef now (maybe I just don't understand, how the entry preview is now supposed to be used) while keeping my user scenario - i. e. quickly cycle through entries and always get a quick summary of the respective entry - I would ask to drop this change or make it optional.

LinusDietz · 2019-08-25T12:22:01Z

Hi @AEgit. I understand your concern, and we should definitely not leave it as it is. If we would keep the entry editor open all the time (unless the user explicitly closes it), would that solve your problem?

AEgit · 2019-08-25T12:25:04Z

Hmmm, that might be a solution, although it also means, that it will use up more of the available screen space. To be honest, I am not a big fan of that - I think the old behaviour was just fine as it was implemented (indeed, other reference managers did it also old way JabRef was doing it). Is there any reason, why this change was introduced at all? I personally don't see the user case (but maybe that is just me).

LinusDietz · 2019-08-25T12:42:38Z

Well, we had our reasons.

You can start editing entries quicker, because the entry editor is already open (this should be fixed as mentioned above)
You immediately see the effect of editing something in the entry preview while you are typing. This is especially important for novice users.
Screen resolutions have become bigger since 2003 (?) when the entry editor and the entry preview were first introduced. Thus, we have the space to display both side by side.

AEgit · 2019-08-25T13:13:26Z

Hmm, ok. Regarding the points:

So far the issue with the entry editor does not seem to be (fully?) resolved. Furthermore, note the problems with the focus (searching terms and then suddenly making changes in the entry editor) makes this change currently dangerous. But I see, what is intended here.
Ok, that makes sense. But then, it would probably be necessary to have a single entry tab (not split among different tabs) - at least, that is how Mendeley is doing this. Personally, I liked it the way JabRef had implemented things before. I am not so sure, whether people are happy with the current solution, i. e. entry preview + open editor (but with multiple entry tabs).
Not so sure about the space. Currently using a 1920x1080 screen, with JabRef using up half of the screen. There, it is definitely too small. At work I have a 4k screen, where JabRef is using up a quarter of the screen (= +- JabRef in full screen on a 1920x1080 screen). I don't think JabRef is supposed to be used in full screen mode. I don't think many people have larger screens (especially when you include laptop users).

johann-petrak · 2019-08-26T10:02:09Z

I would very much like a simple and one-click way to disable showing the citation preview. I spent quite some time looking for it when I got the update since I could not believe that this change was introduced without an option to switch off the preview that takes away space and cpu cycles for keeping it updated.

Siedlerchr · 2019-08-26T10:15:35Z

As this is a merged PR I moved the conversation feedback to a new issue to keep the overview.

tobiasdiez changed the title ~~Include preview in entry editor~~ [WIP] Include preview in entry editor May 17, 2019

Siedlerchr mentioned this pull request May 31, 2019

Entry preview doesn't appear #5012

Closed

victorjof and others added 26 commits July 4, 2019 18:06

Changes array to arrayasList

89d5483

Abbreviates isDateTag() and getDatePriority()

rename variables, add message if file not resolved

c2cacfe

Merge pull request #5068 from JabRef/copyLinkedFilesInContextmenu

add35be

Add copy linked files action to contextmneu in general tab

Use indexOf to find out if a tag is a date

97cfb72

Fixes, added drag'n'drop sorting with multiple selection

9c69bda

Merge remote-tracking branch 'upstream/master' into preferences_previ…

aad6e47

…ew_mvvm

Added Validator and some minor optimizations

e1dc129

Added l10n

eb05d01

Comments

70cebaf

Removed unused method ConfirmRecommendations()

76d5399

Refactor minor things and some rewording

72d93d5

Merge remote-tracking branch 'upstream/master' into preferences_previ…

81359af

…ew_mvvm

Refactor mistake

c3773cd

New translations JabRef_en.properties (Chinese Simplified)

3e8bffe

New translations JabRef_en.properties (Persian)

475bd01

New translations JabRef_en.properties (Turkish)

de22cf9

New translations JabRef_en.properties (Tagalog)

57ca47a

New translations JabRef_en.properties (Swedish)

97b04b9

New translations JabRef_en.properties (Spanish)

025483d

New translations JabRef_en.properties (Russian)

9fdeac0

New translations JabRef_en.properties (Portuguese, Brazilian)

91a97dd

New translations JabRef_en.properties (Norwegian)

aed7d2f

New translations JabRef_en.properties (Danish)

5a7a5f4

New translations JabRef_en.properties (Japanese)

02288c8

koppor and others added 13 commits August 24, 2019 10:31

Merge pull request #5138 from illes/add-conditionals-not

b44acfa

Allow negation (`!`, NOT operator) in \\begin{...} conditionals

fix: database mode is always saved as Biblatex (#5211)

470aa95

Fix double paste (#5210)

4477a13

Fix lookup entry types in enums (#5209)

b00fc22

* Fix lookup entry types in enums Make master work again!!! * fix checkstyle * fix checkstyle and fix type comparison to lower case * simplify remove generics

Minor improvements to TexParser

d271d0b

Co-Authored-By: Oliver Kopp <kopp.dev@gmail.com>

fix: use UTF-8 as default encoding for files ~ resolves #5133

f04a26e

If we create journal abbrev files via the JabRef, they are saved in UTF-8. So it makes sense to use this as default encoding. Also see #5133.

Merge pull request #5212 from davidemdot/minor-texparser-improvements

2130e8e

fix: missing separator for unchanged diff words

19f0d85

Co-authored-by: Linus Dietz <linus@lynyus.de>

Use UTF-8 as default encoding for files (#5213)

7f02c70

Merge pull request #5214 from JabRef/fix-diff-dialog-missing-spaces

72dbfa7

Merge branch 'includePreview' of https://github.com/JabRef/jabref int…

7e08c93

…o includePreview

Merge branch 'includePreview' of https://github.com/JabRef/jabref int…

d321a23

…o include-preview

Removed old entrypreview and corresponding actions

7745e87

Co-authored-by: Stefan Kolb <stefan-kolb@web.de>

stefan-kolb changed the title ~~[WIP] Include preview in entry editor~~ Include preview in entry editor Aug 24, 2019

Merge branch 'include-preview' into include-preview-fix

efc3ca4

LinusDietz mentioned this pull request Aug 24, 2019

Preview in Entryeditor #5218

Merged

LinusDietz closed this Aug 24, 2019

stefan-kolb mentioned this pull request Aug 25, 2019

Unify interface by making entry preview a tab in the "editor" #2115

Closed

tobiasdiez deleted the includePreview branch August 25, 2019 12:30

AEgit mentioned this pull request Aug 25, 2019

Preview not shown upon opening file / Entry editor keybinding flawed #4808

Open

1 task

Siedlerchr mentioned this pull request Aug 26, 2019

Suggestions for improving the entry preview #5244

Closed

JabRef locked and limited conversation to collaborators Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include preview in entry editor #4976

Include preview in entry editor #4976

tobiasdiez commented May 17, 2019 •

edited

Loading

tobiasdiez commented May 31, 2019

matthiasgeiger commented Jun 1, 2019

LinusDietz commented Aug 24, 2019

AEgit commented Aug 25, 2019

LinusDietz commented Aug 25, 2019

AEgit commented Aug 25, 2019

LinusDietz commented Aug 25, 2019

AEgit commented Aug 25, 2019 •

edited

Loading

johann-petrak commented Aug 26, 2019

Siedlerchr commented Aug 26, 2019

Include preview in entry editor #4976

Include preview in entry editor #4976

Conversation

tobiasdiez commented May 17, 2019 • edited Loading

tobiasdiez commented May 31, 2019

matthiasgeiger commented Jun 1, 2019

LinusDietz commented Aug 24, 2019

AEgit commented Aug 25, 2019

LinusDietz commented Aug 25, 2019

AEgit commented Aug 25, 2019

LinusDietz commented Aug 25, 2019

AEgit commented Aug 25, 2019 • edited Loading

johann-petrak commented Aug 26, 2019

Siedlerchr commented Aug 26, 2019

tobiasdiez commented May 17, 2019 •

edited

Loading

AEgit commented Aug 25, 2019 •

edited

Loading