Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let codecov fail during a test #5618

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Let codecov fail during a test #5618

merged 1 commit into from
Nov 18, 2019

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 16, 2019

CoveCov test are allowed to fail (see gradle build file) but the build should fail if there is a problem with the code cov update.

@koppor koppor mentioned this pull request Nov 16, 2019
Merged
2 tasks
tobiasdiez
tobiasdiez approved these changes Nov 16, 2019
View reviewed changes
.travis.yml Outdated
@@ -24,13 +24,14 @@ env:
- TEST_SUITE=fetcherTest
- TEST_SUITE=databaseTest
- TEST_SUITE=guiTest
# codecov may fail by itself (see gradle build file)
# The codecov test itself fails only in case there is an issue with the codecov update. Thus, failing codecov is allowed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A 'not' is missing here, right?

@koppor koppor merged commit 6962745 into master Nov 18, 2019
@koppor koppor deleted the couldcov-may-fail-on-travis branch November 18, 2019 05:33
@koppor
Copy link
Member Author

koppor commented Nov 18, 2019

Travis now sometimes fails with following output (at codecov)

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

The build has been terminated

This was referenced Nov 20, 2019
Merged
Merged
@koppor
Copy link
Member Author

koppor commented Nov 21, 2019

This PR reverted parts of #5609, because of #5609 (comment)

@koppor
Copy link
Member Author

koppor commented Nov 21, 2019

CodeCov should really fail if test coverage decreases. This fosters awareness to add tests.

CodeCov should not fail because of timeouts during tests. At least not if that happens often (as it is currently the case)

I assume the timeout is because some databases started and stopped in parallel and maybe that eats too much cpu, ram, ...

@koppor
Copy link
Member Author

koppor commented Nov 22, 2019

Also fails here: https://travis-ci.org/JabRef/jabref/builds/615330243?utm_source=github_status&utm_medium=notification

Flagged as devcall with the hope, we have time to talk about it today.

@koppor
Copy link
Member Author

koppor commented Nov 22, 2019

Decision: We keep as is and force ourselves to fix the DBMS tests. - Maybe move to GitHub actions for that, too.

@koppor
Copy link
Member Author

koppor commented Dec 22, 2019

Issue tracking this: #5602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @tobiasdiez