Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library access error at BasePanelTest #5655

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 21, 2019

Refs #5602

  • hamcrest wasn't visible --> add it to the test dependencies
  • refine comments on JabRefLauncher and JabRefMain

I could not fix following issue when executing the test in IntelliJ

ARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by net.bytebuddy.description.annotation.AnnotationDescription$ForLoadedAnnotation (file:/C:/Users/olive/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.9.10/211a2b4d3df1eeef2a6cacf78d74a1f725e7a840/byte-buddy-1.9.10.jar) to method com.sun.javafx.beans.IDProperty.value()
WARNING: Please consider reporting this to the maintainers of net.bytebuddy.description.annotation.AnnotationDescription$ForLoadedAnnotation
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
--- Exception in Async Thread ---
java.lang.reflect.InvocationTargetException: null
	java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	java.base/java.lang.reflect.Method.invoke(Method.java:567)
	org.testfx.framework.junit5.ApplicationExtension$AnnotationBasedApplicationFixture.start(ApplicationExtension.java:158)
	org.testfx.framework.junit5.ApplicationAdapter.start(ApplicationAdapter.java:37)

- hamcrest wasn't visible --> add it to the test dependencies
- refine comments on JabRefLauncher and JabRefMain
@koppor
Copy link
Member Author

koppor commented Nov 21, 2019

Regarding travis. Only CodeCov is failing - refs #5618

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

@Siedlerchr
Copy link
Member

Can't we put codecov in allowed failures?

@Siedlerchr Siedlerchr merged commit eb79eba into master Nov 21, 2019
@Siedlerchr Siedlerchr deleted the fix-basepanel-test-execution branch November 21, 2019 10:47
@koppor
Copy link
Member Author

koppor commented Nov 21, 2019

Because of #5609 (comment), it was reenabled. We can discuss it at #5618, where I reenabled codecov failure

koppor pushed a commit that referenced this pull request Oct 15, 2021
3a6a0a7 Update masarykova-univerzita-pravnicka-fakulta.csl (#5655)
136653a Corrections for Conservation Biology style (#5661)
af148f8 Update biophysics-and-physicobiology.csl (#5646)
8842ed1 Create production-and-operations-management.csl (#5654)
6b4965f update style file (#5656)
e5f6066 Update to Ruby 3.0.2 (#5657)
61c530c Reindent/reorder (#5653)
118c217 Update gems (#5652)
46cd9ab harvard-university-of-bath.csl: correct et-al-min (#5651)
37ba705 Create focaal-journal-of-global-and-historical-anthropology.csl (#5649)
e22b8a5 Create developmental-medicine-and-child-neurology.csl (#5644)
f7bc32c Bump nokogiri from 1.11.4 to 1.12.5 (#5640)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 3a6a0a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants