Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update to most recent journal abbreviation list" #5769

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

tobiasdiez
Copy link
Member

This reverts commit d113729.

@koppor I just checked the performance and think the list is too big. Memory increased from about 400mb to 1gb after abbreviating one journal title.

Moreover, the quality of the data seemed way worse than it was before. A lot of abbreviations don't have dots anymore.

Will merge immediately as the unit tests are currently failing.

@tobiasdiez tobiasdiez merged commit 44fdfa7 into master Dec 19, 2019
@tobiasdiez tobiasdiez deleted the revertJournalAbb branch December 19, 2019 19:19
@koppor
Copy link
Member

koppor commented Dec 19, 2019

Thank you for taking action!

For the others: Discussion is going on at #5749

Siedlerchr added a commit that referenced this pull request Dec 20, 2019
# By Tobias Diez (11) and others
# Via GitHub (1) and Tobias Diez (1)
* upstream/master: (29 commits)
  Improve things arround change detection (#5770)
  Revert "Update to most recent journal abbreviation list" (#5769)
  Various fixes to the dark theme (#5764)
  Bump mockito-core from 3.2.0 to 3.2.4 (#5760)
  Bump classgraph from 4.8.58 to 4.8.59 (#5761)
  Improve dependency update rules
  Update jpackage to build 27 (#5758)
  Persistent column sortorder (#5730)
  Fix medline fetcher/importer when using installer (#5752)
  New Crowdin translations (#5751)
  Bump byte-buddy-parent from 1.10.4 to 1.10.5 (#5750)
  Fix checkstyle
  Fix filename
  Update to most recent journal abbreviation list
  Remove obsolete string
  Revert "Switch back to development"
  Switch back to development
  Next development cycle
  Release 5.0-beta (#5684)
  Fix multiple entries allowed in crossref (issue #5284) (#5724)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/collab/ChangeDisplayDialog.java
#	src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants