-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh journal lists periodically #5749
Conversation
What's actually the reason of having them in an extra repository, and not here in the main one? |
I stumbled upon this while reading our howto for releasing a new version: Currently, we collect the data at https://abbrv.jabref.org/. We split the different lists up to fields: For instance, we have a script for fetching the latest abbreviations from https://mathscinet.ams.org. See https://github.com/JabRef/abbrv.jabref.org/blob/master/update_mathscinet.py for details. The split of of the lists helps
What's changed in journalLists.txt(Didn't you ask that - I just made the effort. Mhh...)
TODO:Backport PRs on journalLists.csv / check whether they are included in abbrv.jabref.org
|
What could also work is to include the abbreviation files directly here in this rep, and then run the combine script as part of the build progress. Might reduce the management overhead concerning backporting. Did you checked the performance and memory consumption of the current version? I'm a bit worried that 100k new abbreviations take their toll. |
I think, maintenance in a different repo is easier for users. Not for us,
but I think, there are more potential users and we can get along
maintaining it at two places.
I agree though that JabRef should be more intelligent:
- keep list separate to allow users to relate the available lists with the
list in Jabef
- JabRef should recommend a list automatically. In case I open a bib,
JabRef switches the abbreviation list to the related one. In case there is
none set, auto-select the best fitting.
As an intermediate solution, I would get rid off the combined list and just
import all lists. This combination is a left-over from the early days of
JabRef.
Performance is unchecked. Need to do.
Tobias Diez <notifications@github.com> schrieb am Mo., 16. Dez. 2019, 22:50:
… What could also work is to include the abbreviation files directly here in
this rep, and then run the combine script as part of the build progress.
Did you checked the performance and memory consumption of the current
version? I'm a bit worried that 100k new abbreviations take their toll.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5749?email_source=notifications&email_token=AAKNU7WVPA7NBZD6AKUMCYTQY7Z2LA5CNFSM4J3FAWNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHAHBPA#issuecomment-566259900>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKNU7QLONT4FJXAMO2UUR3QY7Z2LANCNFSM4J3FAWNA>
.
|
Do we have that many contributions to the abbreviation list? I thought it was something like twice per year... |
Even though, it is not that often, I find the homepage https://abbrv.jabref.org more welcoming than a sub directory in the JabRef source with a README.md explaining the contribution. The target group of contributors to JabRef is different from the group contributing to abbrv.jabref.org. The former are people knowing how to code, the latter are just users of JabRef with some IT skills. Maybe, it is no issue for the second group to overlook that they don't need to setup a workspace, they don't need to run tests, ... (see https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md and https://github.com/JabRef/jabref/blob/master/.github/PULL_REQUEST_TEMPLATE.md). I would keep the abbrv repo separate to adress the other target group. Maybe, I should do a study using the GenderMag method by @mendezc1 to more scientifically undermine (or reject) my argument. WDYT @igorsteinmacher? |
Performance test is not necessary any more (#5769)
I wonder about the quality - need to find out when the files diverged. We had the requirement create the list based on our abbreviation list.
|
Please do not update journalList.csv directly. Please update the list at https://github.com/JabRef/abbrv.jabref.org/tree/master/journals |
I modified
From this, However, also The biggest increases come from However, merging all but these three files with journalList.csv gives |
The huge size of the |
Another issue is that abbr.jabref combines both lists with dots in the abbreviation and some lists without dots. I don't think it makes sense to merge them into a single journalList, as you normally want either, but not a mixed style of abbreviations. So it could make sense to maintain two journalLists in the future. |
To backport the changes to Afterwards, I would propose to maintain two lists If you don't want to have too huge indices due to the memory issue, leave out the webofscience lists and people can load them separately if they want this huge extra chunk.
The external lists
|
b8ef7b7
to
21c6e5e
Compare
Another note on the I guess this behaviour is due to the ISI lists being fully capitalized, which was then translated using a first letter capitalized scheme (and I don't see a better way unless they provide an interface to get the non-capitalized lists). So I would argue in favour of keeping them as optional files that are not integrated into the standard journal list(s). Edit: Maybe even add a note on abbrv.jabref site to mention the caveats of these lists! |
Do you know this project: https://github.com/marcinwrochna/abbrevIso It takes the official list of ISO4 abbreviations of single words, plus the general rules defined in the ISO4 specifications to deduce the abbreviation for any journal name you input. Could be an alternative or complementary (when missing in the lists) approach to abbreviate journal names. But of course, it does not handle unabbreviation, for which there is no alternative to lists. It can also be a way to check the consistency of existing lists and it might make sense to link to the frontend on the abbrv.jabref website, so that people who want to add abbreviations can check for the correct one. |
I need to dive into the comments and the delta between the journal lists here and the other repo. Need to think whether we need a combined journal list. Did not have the time formit yet. |
Still need to dive into the comments. Complicated stuff, needs more than one hour concentration. |
We need to work on this for the next release as this (somehow) blocks contributors using IntelliJ 2020.2
|
Thanks to the work by @jlaehne, this was "just" to implement the steps described by @tobiasdiez. |
* upstream/master: Squashed 'src/main/resources/csl-styles/' changes from a8dafef..fad76fe Update journalList.mv Update journalList.mv Fix github-push-action Revert "Try to refresh on master push" Try to refresh on master push Refresh journal lists periodically (#5749) Cancel Previous Workflow Runs (#6826)
60bf7d5 Add encyclopedia type to wikipedia-templates.csl (#5778) 031afe1 Update and rename dependent/organization-studies.csl to organization-… (#5779) 7ed71e7 Update harvard-newcastle-university.csl (#5765) 46bab91 Update annals-of-oncology.csl (#5760) 6158ae6 Create research-in-plant-disease.csl (#5738) 04422a8 Create chemmedchem.csl (#5753) 7c11521 Create clinical-kidney-journal.csl (#5749) e7ee983 Create kit-karlsruher-institut-fur-technologie-germanistik-ndl-neuere… (#5729) 96a1106 Update article format for STM journal (#5755) a4ca057 Update historia-scribere.csl (#5748) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 60bf7d5
Before a release, the journal lists have to be updated manually. With this PR, that is happening periodically. Similar to our CSL files (refs #5718)