Refine IntelliJ howto to enable built-in compiler again #6794
Conversation
docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md
Outdated
Show resolved
Hide resolved
docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md
Outdated
Show resolved
Hide resolved
|  | ||
| * Add the folder `src/main/gen` as generated sources root | ||
|  | ||
| * Delete `org.jabref.gui.logging.plugins.Log4jPlugins`. Otherwise, you will see folowing error: |
There was a problem hiding this comment.
This step should only be necessary for developers that used the old version (where the log4jplugin was created in a different folder).
There was a problem hiding this comment.
After gradlew run, the file is generated. I checked it with latest master. Thus, the file always has to be deleted.
There was a problem hiding this comment.
Yes, it should be generated in "src/main/gen" because of https://github.com/JabRef/jabref/blob/master/build.gradle#L376. But that's exactly what it's designed to do. So I'm not sure why you would want to remove this file. It's needed to build.
There was a problem hiding this comment.
When removing it, the internal IntelliJ compiler perfectly compiles. When it is present, IntelliJ 2020.1 fails with the error.
Is it different on your side?
(I am not talking about the gradle build. I aim for offering all available build chains (IntelliJ build-in and gradle) to the users)
koppor
added
the
status: ready-for-review
|
Status: Waiting for merge of #6800 (review). Then, I will try from scratch again. |
# Conflicts: # docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md
… refine-intellij-howto # Conflicts: # docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md
|
I field https://youtrack.jetbrains.com/issue/IDEA-249391 and updated the text accordingly. Rendered output at https://github.com/JabRef/jabref/blob/refine-intellij-howto/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md. |
|
Even with Log4JPlugins present, it does not run on my side:
|
| @@ -88,26 +88,27 @@ These steps are very important. They allow you to focus on the content and ensur | |||
|
|
|||
| ### Setup for IntelliJ IDEA | |||
|
|
|||
| IntelliJ IDEA fully supports Gradle as a build tool, but also has an internal build system which is usually faster. For JabRef, Gradle is required to make a full build but once set up, IntelliJ IDEA's internal system can be used for sub-sequent builds. | |||
| We recommend to install IntelliJ IDEA using [JetBrains Toolbox App](https://www.jetbrains.com/toolbox-app/), because IDE updates are automatically installed. | |||
There was a problem hiding this comment.
As these installation notes are already pretty extensive, I would try to reduce them to the minimum. How Intellj is installed is best installed is something a user can figure out themselves I think. Also the "checked for" paragraph is not really helpful for a new dev in my opinion.
There was a problem hiding this comment.
Removed the "checked for", but kept the recommendation (based on my teaching experience).
There was a problem hiding this comment.
For people who are new to the project, anything that would make them more comfortable and show them the steps towards that is great.
Pointing to the "default" IDE, is a point that helps a lot and in JabRef cases facilitates (even if some 'mentoring' is required)
|
No idea where this error is coming from...maybe its a conflicting gradle setting (maybe remove generated from sourceset?). Strange thing is that the code analysis works, its only the build that complains about the missing import.... |
tobiasdiez
added
status: changes required
koppor
removed
the
status: changes required
…torShutdown * upstream/master: Add connection check to NetworkTab in preferences (#6838) Refine IntelliJ howto to enable built-in compiler again (#6794) GitBook: [master] one page modified GitBook: [master] 3 pages and 3 assets modified Add missing } Refactor of remaining preference tabs to PreferencesService (#6836) ChipView for crossref and groups (#6228) Ignore codecov.io at external link check Fix linting issues Add "m-mauersberger" Update journalList.mv
* upstream/master: Add connection check to NetworkTab in preferences (#6838) Refine IntelliJ howto to enable built-in compiler again (#6794) GitBook: [master] one page modified GitBook: [master] 3 pages and 3 assets modified Add missing } Refactor of remaining preference tabs to PreferencesService (#6836) ChipView for crossref and groups (#6228) Ignore codecov.io at external link check Fix linting issues Add "m-mauersberger" Update journalList.mv
I had huge troubles running the IntelliJ internal compiler.
I had to go back to IntelliJ 2020.1 and to do some other configuration tweaks. These are added here.Update: I cannot get 2020.1 working again.Refs #6749