Icons from Material design icons not recognized

[stefan-kolb]

Fixes #6078
Related #5245

@JabRef/developers 2b760cd caused this issue.
#5245
Obviously only icons contained inside JabRefIcons are available now.

The question is - do we really want this feature? Not sure if changing the line back to

        return Enums.getIfPresent(MaterialDesignIcon.class, iconCode.toUpperCase(Locale.ENGLISH))
                    .toJavaUtil()
                    .map(icon -> new InternalMaterialDesignIcon(getColor(), icon));

will reintroduce the referenced issue (#5245).
This feature also only makes sense, if we have a dropdown with all available icons inside the new/edit group dialog IMHO.

[codecov]

Codecov Report

Merging #6121 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #6121      +/-   ##
============================================
- Coverage     41.55%   41.54%   -0.01%     
- Complexity     6878     6879       +1     
============================================
  Files          1090     1090              
  Lines         46233    46233              
  Branches       5557     5557              
============================================
- Hits          19211    19208       -3     
- Misses        25575    25577       +2     
- Partials       1447     1448       +1

Impacted Files	Coverage Δ	Complexity Δ
...java/org/jabref/gui/groups/GroupNodeViewModel.java	61.68% <0%> (ø)	23 <0> (ø)	⬇️
...jabref/logic/shared/event/ConnectionLostEvent.java	0% <0%> (-75%)	0% <0%> (-1%)
...bref/logic/remote/server/RemoteListenerServer.java	70.96% <0%> (-6.46%)	7% <0%> (ø)
...a/org/jabref/logic/shared/PostgreSQLProcessor.java	79.59% <0%> (-4.09%)	10% <0%> (ø)
...java/org/jabref/logic/shared/DBMSSynchronizer.java	70.7% <0%> (-1.92%)	39% <0%> (-2%)
...in/java/org/jabref/logic/shared/DBMSProcessor.java	82.48% <0%> (-1.7%)	46% <0%> (ø)
...ef/logic/importer/fetcher/AbstractIsbnFetcher.java	100% <0%> (+11.11%)	5% <0%> (+1%)	⬆️
...org/jabref/logic/importer/fetcher/IsbnFetcher.java	89.47% <0%> (+36.84%)	8% <0%> (+1%)	⬆️
.../logic/importer/fetcher/IsbnViaEbookDeFetcher.java	100% <0%> (+41.66%)	5% <0%> (+2%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd7444...c29db2e. Read the comment docs.

[Siedlerchr]

I doubt this works.

[stefan-kolb]

I doubt this works.

It does. At least starting from gradle run. What are your doubts?

[Siedlerchr]

Please test also with ./gradlew jlink it will build the image locally and you can start the bat.
It makes a huge difference if it is packaged together or executed from gradle

[stefan-kolb]

Please test also with ./gradlew jlink it will build the image locally and you can start the bat.
It makes a huge difference if it is packaged together or executed from gradle

Works for me /started via JabRef.bat). I can set the group icon. Any other side effects I need to check?

[Siedlerchr]

If this works, then other cases should also work.
Have you tested saving your bib file with groups and icon and closing and reopening that bib file then?
If this works as well, it will be good to go

[stefan-kolb]

If this works, then other cases should also work.
Have you tested saving your bib file with groups and icon and closing and reopening that bib file then?
If this works as well, it will be good to go

Saving and reopening worked.

[Siedlerchr]

So apparently this works fine. So we can merge it

[calixtus]

Agreed.

[tobiasdiez]

Please also add a changelog.