Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CCSB and DOAJ #7426

Merged
merged 26 commits into from
May 1, 2021
Merged

Fix CCSB and DOAJ #7426

merged 26 commits into from
May 1, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 7, 2021

This aligns the implementation to the documentation.

Some fetchers still need to be checked.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor
Copy link
Member Author

koppor commented Feb 8, 2021

User documentation update: JabRef/user-documentation#348

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests for this as well? Thanks! Otherwise it looks good to me.

@tobiasdiez
Copy link
Member

What's the status here?

@tobiasdiez tobiasdiez added the status: changes required Pull requests that are not yet complete label Mar 10, 2021
@koppor
Copy link
Member Author

koppor commented Mar 11, 2021

@tobiasdiez I did not find time yet to write the tests. Please give me some time to dive into this again.

We also have a devcall on Monday. Would you like to participate, please?

@koppor koppor removed the status: changes required Pull requests that are not yet complete label Mar 21, 2021
@koppor
Copy link
Member Author

koppor commented Mar 21, 2021

Only other tests fail. Would it be OK to finally review these changes and merge? Then we can work on fixing the fetchers.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 21, 2021
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last remark

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 28, 2021
@calixtus
Copy link
Member

calixtus commented May 1, 2021

Since the remark of tobias is fixed and besides this fix the changes were minimal we are going to merge this now. Some small follow-up issues were create in koppors fork. Plan is to fix the fetchers now one by one with a pr for each.

@koppor koppor mentioned this pull request May 1, 2021
3 tasks
@calixtus calixtus merged commit 6e99a33 into main May 1, 2021
@calixtus calixtus deleted the fix-ccsb branch May 1, 2021 14:55
Siedlerchr added a commit that referenced this pull request May 4, 2021
* upstream/main: (354 commits)
  Fix ScienceDirect fetcher (#7684)
  Refactor NoBibTexFieldCheckerTest to increase mutation coverage (#7697)
  Update Gradle from 6.8.3 to 7.0 (#7619)
  Fixes #7305: the RFC fetcher is not compatible with the draftFix for issue 7305 (#7674)
  Refactoring existing unit tests (#7693)
  cover boundary cases & add more unit tests (#7694)
  Bump classgraph from 4.8.104 to 4.8.105 (#7688)
  Bump java-diff-utils from 4.9 to 4.10 (#7692)
  Fix arXiv fetcher tests (#7686)
  Make key for ScienceDirect configurable (#7683)
  migration of timestamp (#7671)
  Fix CCSB and DOAJ (#7426)
  [Bot] Update CSL styles (#7680)
  MS Office XML: Export month name (#7677)
  linkfix (#7678)
  readd fix (#7675)
  Fix threading cleanup in performSearch (#7672)
  add missing changelog
  delete bug fix (#7580)
  Add more unit tests to three gui classes  (#7636)
  ...

# Conflicts:
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants