Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScienceDirect fetcher #7684

Merged
merged 8 commits into from
May 4, 2021
Merged

Fix ScienceDirect fetcher #7684

merged 8 commits into from
May 4, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented May 2, 2021

For the test PDF, the json structure does not contain the full text any more. One has to use other meta data. This PR does that

Excerpt of new meta data:

    "pdfDownload": {
      "linkType": "DOWNLOAD",
      "isPdfFullText": false,
      "urlMetadata": {
        "queryParams": {
          "md5": "2b19b19a387cffbae237ca6a987279df",
          "pid": "1-s2.0-S1674775515001079-main.pdf"
        },
        "pii": "S1674775515001079",
        "pdfExtension": "/pdfft",
        "path": "science/article/pii"
      }
    },
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor added the fetcher label May 2, 2021
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 2, 2021
@Siedlerchr Siedlerchr merged commit 3fb1176 into main May 4, 2021
@Siedlerchr Siedlerchr deleted the fix-sciencedirect branch May 4, 2021 05:58
Siedlerchr added a commit that referenced this pull request May 4, 2021
* upstream/main: (354 commits)
  Fix ScienceDirect fetcher (#7684)
  Refactor NoBibTexFieldCheckerTest to increase mutation coverage (#7697)
  Update Gradle from 6.8.3 to 7.0 (#7619)
  Fixes #7305: the RFC fetcher is not compatible with the draftFix for issue 7305 (#7674)
  Refactoring existing unit tests (#7693)
  cover boundary cases & add more unit tests (#7694)
  Bump classgraph from 4.8.104 to 4.8.105 (#7688)
  Bump java-diff-utils from 4.9 to 4.10 (#7692)
  Fix arXiv fetcher tests (#7686)
  Make key for ScienceDirect configurable (#7683)
  migration of timestamp (#7671)
  Fix CCSB and DOAJ (#7426)
  [Bot] Update CSL styles (#7680)
  MS Office XML: Export month name (#7677)
  linkfix (#7678)
  readd fix (#7675)
  Fix threading cleanup in performSearch (#7672)
  add missing changelog
  delete bug fix (#7580)
  Add more unit tests to three gui classes  (#7636)
  ...

# Conflicts:
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants